We encountered a problem of the rendering of mj-group in the KaufmannDigital.EmailEditing:MjmlElementRenderer used for the html-Rendering in Components inheriting from KaufmannDigital.EmailEditing:ContentComponent.DualRendering.
Current Behavior:
mj-column inside of mj-group is stacked in the browser-view of neos, on mobile devices.
Expected Behavior:
mj-column inside of mj-group is in an equal row in the browser-view of neos, on mobile devices.
Reason we found:
In Classes/Fusion/FusionObjects/MjmlElementRendererImplementation.php get the styles extracted via regex (l.88). They are applied again on l.90 to be able to modify the body in between. The extraction of the styles does not respect the styles applied to ms-office via conditional comments usually rendered by mjml. So all styles which should only be applied to ms-office are applied to every browser, which breaks mj-group in behavior in other browsers.
So my question is: Why is it necessary to modify the html, explcitly to replace the p-tags by div-tags? In a quick comparison I did not see any change in the neos frontend or backend when using the plain mjml-generated html, but gain the original logic of conditional comments.
I also prepared a patch for it, to remove conditional mso-styles in the styles group. I will link the issue there.
We encountered a problem of the rendering of
mj-groupin theKaufmannDigital.EmailEditing:MjmlElementRendererused for the html-Rendering in Components inheriting fromKaufmannDigital.EmailEditing:ContentComponent.DualRendering.Current Behavior:
mj-columninside ofmj-groupis stacked in the browser-view of neos, on mobile devices.Expected Behavior:
mj-columninside ofmj-groupis in an equal row in the browser-view of neos, on mobile devices.Reason we found:
In
Classes/Fusion/FusionObjects/MjmlElementRendererImplementation.phpget the styles extracted via regex (l.88). They are applied again on l.90 to be able to modify the body in between. The extraction of the styles does not respect the styles applied to ms-office via conditional comments usually rendered by mjml. So all styles which should only be applied to ms-office are applied to every browser, which breaks mj-group in behavior in other browsers.So my question is: Why is it necessary to modify the html, explcitly to replace the p-tags by div-tags? In a quick comparison I did not see any change in the neos frontend or backend when using the plain mjml-generated html, but gain the original logic of conditional comments.
I also prepared a patch for it, to remove conditional mso-styles in the styles group. I will link the issue there.