Skip to content

fix: remove outlook only styles from mjmlElementRendererImplementation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonaphil wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: remove outlook only styles from mjmlElementRendererImplementation #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Classes/Fusion/FusionObjects/MjmlElementRendererImplementation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,13 @@ public function evaluate()
->validationLevel(ValidationLevel::Skip)
->toHtml($mjml);

// Outlook-only rules are applyed conditionally
// (e.g. .mj-outlook-group-fix, which forces mj-group columns to width:100% and breaks side-by-side layout everywhere else).
// We remove them to don't get the styles for outlook applied, which breaks mj-group in all other browsers.
$htmlWithoutMsoConditionals = preg_replace('/<!--\[if[^\]]*mso[^\]]*\]>[\s\S]*?<!\[endif\]-->/', '', $html);

preg_match('/<body[^>]*>([\s\S]*?)<\/body>/', $html, $bodyMatches);
preg_match_all('/<style[^>]*>([\s\S]*?)<\/style>/', $html, $styleMatches);
preg_match_all('/<style[^>]*>([\s\S]*?)<\/style>/', $htmlWithoutMsoConditionals, $styleMatches);

$body = $bodyMatches[1];

Expand Down