Refactor/type hinting pep561#37
Merged
KaykCaputo merged 2 commits intoKaykCaputo:masterfrom Apr 12, 2026
Merged
Conversation
waldo121
force-pushed
the
refactor/type-hinting-pep561
branch
from
267d3eb to
48cc6f0
Compare
waldo121
force-pushed
the
refactor/type-hinting-pep561
branch
from
48cc6f0 to
02b6df3
Compare
Owner
|
@AndreXP1 could you please review this? |
Contributor
|
Instead of dictionaries we should be using dataclasses where applicable |
vincent5678
suggested changes
Apr 11, 2026
Contributor
There was a problem hiding this comment.
Should be a dataclass instead of dictionary
waldo121
commented
Apr 11, 2026
waldo121
force-pushed
the
refactor/type-hinting-pep561
branch
from
02b6df3 to
876fcd3
Compare
waldo121
force-pushed
the
refactor/type-hinting-pep561
branch
from
876fcd3 to
21fb4ae
Compare
AndreXP1
approved these changes
Apr 11, 2026
Collaborator
AndreXP1
left a comment
AndreXP1
left a comment
There was a problem hiding this comment.
Nice!
Can we merge this? @KaykCaputo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds type hints and CI check
Related Issue
Closes #36
Type of Change
What Changed
List the key changes in a few bullets.
py.typedin module rootValidation
Describe how you validated this change.
mypy oracletracepytest testsChecklist
Additional Notes
Is there a preferred order for CI checks?