fix DocSpace parentship

Author: wadoon

key.core/src/main/java/de/uka/ilkd/key/ldt/FinalHeapResolution.java

@@ -3,6 +3,8 @@
  * SPDX-License-Identifier: GPL-2.0-only */
 package de.uka.ilkd.key.ldt;
 
+import java.util.Objects;
+
 import de.uka.ilkd.key.proof.init.InitConfig;
 import de.uka.ilkd.key.settings.ProofSettings;
 
@@ -51,8 +53,8 @@ public static boolean isFinalEnabled(@NonNull InitConfig initConfig) {
      * @return true if final fields are treated as immutable
      */
     public static boolean isFinalEnabled(@NonNull ProofSettings settings) {
-        return settings.getChoiceSettings().getDefaultChoices().get(SETTING)
-                .equals(IMMUTABLE_OPTION);
+        return Objects.equals(settings.getChoiceSettings().getDefaultChoices().get(SETTING),
+            IMMUTABLE_OPTION);
     }
 
     /**

key.core/src/main/java/de/uka/ilkd/key/logic/DocSpace.java

@@ -26,6 +26,11 @@ public DocSpace(DocSpace parent) {
         this.parent = parent;
     }
 
+    public DocSpace(@Nullable DocSpace parent, Map<String, String> documentation) {
+        this(documentation);
+        this.parent = parent;
+    }
+
     public @Nullable String find(String key) {
         var value = documentation.get(key);
         if (value != null)
@@ -59,6 +64,6 @@ public void describe(HasDocumentation entity, @Nullable String doc) {
     }
 
     public DocSpace copy() {
-        return new DocSpace(documentation);
+        return new DocSpace(parent, documentation);
     }
 }

key.core/src/main/java/de/uka/ilkd/key/logic/NamespaceSet.java

@@ -4,6 +4,8 @@
 package de.uka.ilkd.key.logic;
 
 
+import java.util.Objects;
+
 import de.uka.ilkd.key.logic.op.IProgramVariable;
 import org.jspecify.annotations.NullMarked;
 import de.uka.ilkd.key.logic.op.ParametricFunctionDecl;
@@ -32,7 +34,7 @@ public class NamespaceSet {
     private Namespace<ParametricSortDecl> parametricSortNS = new Namespace<>();
     private Namespace<ParametricFunctionDecl> parametricFuncNS = new Namespace<>();
     private Namespace<Choice> choiceNS = new Namespace<>();
-    private final DocSpace documentation = new DocSpace();
+    private DocSpace documentation = new DocSpace();
 
     public NamespaceSet() {
     }
@@ -65,7 +67,7 @@ public NamespaceSet(Namespace<QuantifiableVariable> varNS,
         this.choiceNS = choiceNS;
         this.parametricSortNS = parametricSortNS;
         this.parametricFuncNS = parametricFuncNS;
-        this.documentation.add(documentation);
+        this.documentation = Objects.requireNonNull(documentation);
     }
 
 
@@ -89,7 +91,8 @@ public NamespaceSet copyWithParent() {
             new Namespace<>(functions()), new Namespace<>(sorts()),
             new Namespace<>(ruleSets()), new Namespace<>(parametricSorts()),
             new Namespace<>(parametricFunctions()), new Namespace<>(choices()),
-            new Namespace<>(programVariables()));
+            new Namespace<>(programVariables()),
+            new DocSpace(documentation));
     }
 
     public Namespace<QuantifiableVariable> variables() {
@@ -258,13 +261,13 @@ public boolean isEmpty() {
     public NamespaceSet simplify() {
         return new NamespaceSet(varNS.simplify(), funcNS.simplify(), sortNS.simplify(),
             ruleSetNS.simplify(), parametricSortNS.simplify(), parametricFuncNS.simplify(),
-            choiceNS.simplify(), progVarNS.simplify());
+            choiceNS.simplify(), progVarNS.simplify(), documentation);
     }
 
     public NamespaceSet getCompression() {
         return new NamespaceSet(varNS.compress(), funcNS.compress(), sortNS.compress(),
             ruleSetNS.compress(), parametricSortNS.compress(), parametricFuncNS.compress(),
-            choiceNS.compress(), progVarNS.compress());
+            choiceNS.compress(), progVarNS.compress(), documentation);
     }
 
     public void flushToParent() {