Dependency Contract: Ignore all term labels when searching for base term#3776
Merged
wadoon merged 2 commits intoKeYProject:mainfrom Mar 27, 2026
Merged
Dependency Contract: Ignore all term labels when searching for base term#3776wadoon merged 2 commits intoKeYProject:mainfrom
wadoon merged 2 commits intoKeYProject:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3776 +/- ##
============================================
+ Coverage 50.29% 50.48% +0.19%
- Complexity 15986 16158 +172
============================================
Files 1605 1620 +15
Lines 91528 92011 +483
Branches 14662 14705 +43
============================================
+ Hits 46035 46455 +420
- Misses 40228 40292 +64
+ Partials 5265 5264 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dafabc8 to
b24c9e5
Compare
WolframPfeifer
approved these changes
Mar 25, 2026
Member
WolframPfeifer
left a comment
There was a problem hiding this comment.
As discussed during our meeting, I don't see any reason why the code determining the base term for dependency contract application should respect any of the term labels. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request resolves #3760.
Intended Change
None of the term labels should affect applicability of this rule
Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.