Skip to content

Dependency Contract: Ignore all term labels when searching for base term#3776

Merged
wadoon merged 2 commits intoKeYProject:mainfrom
FliegendeWurst:udc-labels
Mar 27, 2026
Merged

Dependency Contract: Ignore all term labels when searching for base term#3776
wadoon merged 2 commits intoKeYProject:mainfrom
FliegendeWurst:udc-labels

Conversation

@FliegendeWurst
Copy link
Copy Markdown
Member

Related Issue

This pull request resolves #3760.

Intended Change

None of the term labels should affect applicability of this rule

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • There are changes to the (Java) code

Ensuring quality

  • I have tested the feature as follows: manually using the case from the issue

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.48%. Comparing base (b24c9e5) to head (7d01c6c).
⚠️ Report is 253 commits behind head on main.

Files with missing lines Patch % Lines
...e/uka/ilkd/key/rule/UseDependencyContractRule.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3776      +/-   ##
============================================
+ Coverage     50.29%   50.48%   +0.19%     
- Complexity    15986    16158     +172     
============================================
  Files          1605     1620      +15     
  Lines         91528    92011     +483     
  Branches      14662    14705      +43     
============================================
+ Hits          46035    46455     +420     
- Misses        40228    40292      +64     
+ Partials       5265     5264       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@WolframPfeifer WolframPfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed during our meeting, I don't see any reason why the code determining the base term for dependency contract application should respect any of the term labels. Thanks for the fix!

@WolframPfeifer WolframPfeifer changed the title Use Dependency Contract: ignore all term labels Dependency Contract: Ignore all term labels when searching for base term Mar 25, 2026
@wadoon wadoon added this pull request to the merge queue Mar 27, 2026
Merged via the queue into KeYProject:main with commit 7aaf2ce Mar 27, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

anonHeapFunction label prevents use of Dependency Contract

3 participants