NodeIntermediateWalker: optimize stack space usage#3789
Closed
FliegendeWurst wants to merge 1 commit intoKeYProject:mainfrom
Closed
NodeIntermediateWalker: optimize stack space usage#3789FliegendeWurst wants to merge 1 commit intoKeYProject:mainfrom
FliegendeWurst wants to merge 1 commit intoKeYProject:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3789 +/- ##
============================================
+ Coverage 50.34% 50.48% +0.14%
- Complexity 15902 16158 +256
============================================
Files 1597 1620 +23
Lines 91026 92009 +983
Branches 14554 14704 +150
============================================
+ Hits 45824 46455 +631
- Misses 39988 40290 +302
- Partials 5214 5264 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FliegendeWurst
force-pushed
the
niw-optimize
branch
from
3223f9c to
b24971b
Compare
Member
|
@FliegendeWurst I actually had a fix for that in a different project a while ago, which I forgot to bring to main. I created PR #3793 now, which I would prefer over this one, as it goes one step further and completely removes recursion. Can you check if that also works for you? Thanks! |
Member
|
Replaced by #3793. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, the proof management tool may throw a StackOverflowError for very large proofs (the largest in my case has 461059 nodes).
Intended Change
Use iteration in the node walker when possible.
This is done by checking for the common case of a single child node.
Type of pull request
Optimization / bug fix
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.