Skip to content

Alternative for #3393: Fix slicing bug related to Evaluate Query#3794

Merged
wadoon merged 1 commit intomainfrom
pfeifer/slicing-fix-3393-alternative
Mar 27, 2026
Merged

Alternative for #3393: Fix slicing bug related to Evaluate Query#3794
wadoon merged 1 commit intomainfrom
pfeifer/slicing-fix-3393-alternative

Conversation

@WolframPfeifer
Copy link
Copy Markdown
Member

This PR brings the fixes from #3393 to current main by manually transferring the changes. This was necessary since in the meantime, equality modulo proofs is implemented completely differently.

Since a lot of time has passed, I can also provide the problematic example now (was from a student exercise):

The proof was not sliceable on main (exception: "proof replayer failed to find dynamically added taclet"), but is with the changes from this PR.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • There are changes to the (Java) code

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I have tested the feature as follows: Manually with the given example

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@WolframPfeifer WolframPfeifer added this to the v3.0.0 milestone Mar 27, 2026
@WolframPfeifer WolframPfeifer self-assigned this Mar 27, 2026
@WolframPfeifer WolframPfeifer added 🐞 Bug keyext.slicing Module: keyext.slicing labels Mar 27, 2026
@wadoon wadoon added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit f1abe03 Mar 27, 2026
36 checks passed
@wadoon wadoon deleted the pfeifer/slicing-fix-3393-alternative branch March 27, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keyext.slicing Module: keyext.slicing 🐞 Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants