Fix pruning of cached branches#3858
Merged
Merged
Conversation
WolframPfeifer
approved these changes
Jul 7, 2026
WolframPfeifer
left a comment
WolframPfeifer
left a comment
Member
There was a problem hiding this comment.
The call to refreshGoal() indeed seems to have the desired effect, and in my manual tests the pruning seems to work as expected. Thanks!
One thing that I noticed: If you prune a goal closed via cache directly, and then open and close the "Proof Caching" dialog from the status bar, it is closed directly again. Apparently closing the dialog triggers a cache check. I don't think this behavior is a problem, just a little bit unexpected maybe, and would keep it like this for now.
Member
|
Weird: In the test cases, the list of open goals again has a |
Member
|
@FliegendeWurst The newly implemented functionality for pruning is inconsistent with the test in line 79-81 of TestReferenceSearcher. Could you have a look? |
unp1
reviewed
Jul 7, 2026
On Linux (KDE, Wayland) setLocationByPlatform does not work properly. The window is positioned in the top-left corner instead of center.
FliegendeWurst
force-pushed
the
cachingFixes
branch
2 times, most recently
from
483fd83 to
4448f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request resolves #3846.
Intended Change
Two bugfixes
The second part is done almost exactly like in #3440. I tested both the minimal prune (prune directly at the cached node), and a larger (multi-branch) prune.
I added a
refreshGoalcall, in case it helps.Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.