Ensure default option for pruning/disposing of cache sources is set properly#3901
Open
WolframPfeifer wants to merge 1 commit into
Open
Ensure default option for pruning/disposing of cache sources is set properly#3901WolframPfeifer wants to merge 1 commit into
WolframPfeifer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small bugfix that sets the default values for two settings of the caching extension:
Both have two options: "Copy" or "Reopen" (compare to the screenshot in #3469), where the former transfers the steps, and the latter silently reopens the affected branches.
Since the default was not set properly (empty string returned), the first option in the combo box was selected, which happened to be the unsafe option ("Reopen") when pruning. For disposing, the default was correct (although not properly set), because the combo box had "Copy" as first entry.
This PR sets both options to the safe variant "Copy" to avoid silently reopening any branches the user might have thought of as closed.
Related Issue
Partially fixes #3469, even if it still remains a valid feature request.
Type of pull request
Ensuring quality
~/.key/proofIndependentSettings.json)The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.