Skip to content

Ensure default option for pruning/disposing of cache sources is set properly#3901

Open
WolframPfeifer wants to merge 1 commit into
mainfrom
pfeifer/cachingDisposeSourceDefault
Open

Ensure default option for pruning/disposing of cache sources is set properly#3901
WolframPfeifer wants to merge 1 commit into
mainfrom
pfeifer/cachingDisposeSourceDefault

Conversation

@WolframPfeifer

Copy link
Copy Markdown
Member

This is a small bugfix that sets the default values for two settings of the caching extension:

  1. Pruning a branch used as cache source automatically copies the steps to the target node where the cache hit occurred.
  2. Disposing a proof that was used as cache source automatically copies the steps to the target proof.

Both have two options: "Copy" or "Reopen" (compare to the screenshot in #3469), where the former transfers the steps, and the latter silently reopens the affected branches.

Since the default was not set properly (empty string returned), the first option in the combo box was selected, which happened to be the unsafe option ("Reopen") when pruning. For disposing, the default was correct (although not properly set), because the combo box had "Copy" as first entry.

This PR sets both options to the safe variant "Copy" to avoid silently reopening any branches the user might have thought of as closed.

Related Issue

Partially fixes #3469, even if it still remains a valid feature request.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)

Ensuring quality

  • I have tested the feature as follows: manually checked in the GUI that indeed the set defaults are applied, and also persisting a set option across KeY runs still works (settings are correctly written to ~/.key/proofIndependentSettings.json)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI keyext.caching Module: keyext.caching 🐞 Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ask before closing a proof whose branches are "used" in other proofs

1 participant