Add user-defined strategy presets to the strategy options pane#3902
Open
unp1 wants to merge 1 commit into
Open
Add user-defined strategy presets to the strategy options pane#3902unp1 wants to merge 1 commit into
unp1 wants to merge 1 commit into
Conversation
Besides the built-in presets, users can now:
- save the current strategy settings as a named preset ("Save current as…"),
- stash them into a single reusable "Stash" slot (overwritten each time),
- rename a preset, and
- delete a preset via a small "x" on its row in the combo box dropdown.
Presets capture the current strategy properties and max. rule
applications, are stored in the proof-independent settings
(Configuration/JSON) and survive restarts.
Implementation:
- new StrategyPresetsSettings (key.core), registered in
ProofIndependentSettings;
- StrategySelectionView reworked to a typed PresetEntry combo box model
with a custom renderer (per-row delete affordance + built-in/user
separator) and an adjacent gear menu for save/stash/rename;
- tests covering the Configuration persistence round-trip and the
add/overwrite/stash/rename/remove bookkeeping.
Created with AI tooling support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
The strategy pane offered already a few built-in presets. This PR extends the functionality by allowing the user to save their own presets.
A "stash" options allows to quickly save the current strategy options so that one can return quickly back to them. Stashes are tought for quick, non-persistent capturing of the current strategy properties without giving them a name and/or making them persistent.
Functionalities:
Presets capture the current strategy properties and max. rule
applications, are stored in the proof-independent settings and survive restarts.
Type of pull request
Ensuring quality
Additional information and contact(s)
Created with AI tooling support
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.