Fix formatting in Ed25519 key serialization (#485)

scovetta · web-flow · commit 9934c7fe3aa7 · 2026-02-22T13:17:20.000+01:00
In the thumbprint() function, the serialized format of the Ed25519 curve is missing double quotes around "crv", which would likely affect interoperability between other implementations. Fixes #484
diff --git a/src/jwk.rs b/src/jwk.rs
@@ -531,7 +531,7 @@ impl Jwk {
                 }
                 EllipticCurve::Ed25519 => {
                     format!(
-                        r#"{{crv:{},"kty":{},"x":"{}"}}"#,
+                        r#"{{"crv":{},"kty":{},"x":"{}"}}"#,
                         serde_json::to_string(&a.curve).unwrap(),
                         serde_json::to_string(&a.key_type).unwrap(),
                         a.x,

Original file line number	Diff line number	Diff line change
`@@ -531,7 +531,7 @@ impl Jwk {`
`531`	`531`	`}`
`532`	`532`	`EllipticCurve::Ed25519 => {`
`533`	`533`	`format!(`
`534`		`- r#"{{crv:{},"kty":{},"x":"{}"}}"#,`
	`534`	`+ r#"{{"crv":{},"kty":{},"x":"{}"}}"#,`
`535`	`535`	`serde_json::to_string(&a.curve).unwrap(),`
`536`	`536`	`serde_json::to_string(&a.key_type).unwrap(),`
`537`	`537`	`a.x,`