rand() swapped with std::mt19937 (#112)

Author: nc-gp

KBotExt/Definitions.h

@@ -3,7 +3,7 @@
 #include <vector>
 #include <string>
 
-#define RandomInt(min, max) (rand() % (max - min + 1) + min)
+//#define RandomInt(min, max) (rand() % (max - min + 1) + min)
 
 struct ChampMinimal
 {

KBotExt/KBotExt.cpp

@@ -79,10 +79,10 @@ int WINAPI wWinMain(HINSTANCE /*hInstance*/, HINSTANCE /*hPrevInstance*/, LPWSTR
 #endif
 
 		//Randomize using current time, todo swap with recent c++ random
-		srand(static_cast<unsigned>(time(0)));
+		//srand(static_cast<unsigned>(time(0)));
 
 		Config::Load();
-		std::wstring sClassName = Utils::RandomWString(RandomInt(5, 10), { 0x2e80, 0xfffff });
+		std::wstring sClassName = Utils::RandomWString(Utils::RandomInt(5, 10), { 0x2e80, 0xfffff });
 		LPCWSTR lpszOverlayClassName = sClassName.c_str();
 		//Register window class information
 		WNDCLASSEXW wc = { sizeof(WNDCLASSEXW), CS_CLASSDC, WndProc, 0L, 0L, GetModuleHandle(NULL), NULL, NULL, NULL, NULL, sClassName.c_str(), NULL };

KBotExt/Utils.cpp

@@ -4,13 +4,23 @@
 #include <filesystem>
 #include <array>
 #include <cwctype>
+#include <random>
 //URLDownloadToFileA
 #include <urlmon.h>
 #pragma comment(lib, "urlmon.lib")
 
 #include "Utils.h"
 #include "Definitions.h"
 
+int Utils::RandomInt(int min, int max)
+{
+	std::random_device rd;
+	std::mt19937 gen(rd());
+	std::uniform_int_distribution<> distr(min, max);
+
+	return distr(gen);
+}
+
 std::string Utils::ToLower(std::string str)
 {
 	std::transform(str.begin(), str.end(), str.begin(),

KBotExt/Utils.h

@@ -7,6 +7,8 @@ class Utils
 	Utils() = default;
 	~Utils() = default;
 
+	static int RandomInt(int min, int max);
+
 	static std::string ToLower(std::string str);
 	static std::wstring ToLower(std::wstring wstr);