diff --git a/kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java b/kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java index 7f68861d..a16f4302 100644 --- a/kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java +++ b/kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java @@ -202,6 +202,8 @@ private void updateTapDetails() { final TextView title = ButterKnife.findById(mView, R.id.tapTitle); final TextView subtitle = ButterKnife.findById(mView, R.id.tapSubtitle); + final TextView abvText = ButterKnife.findById(mView, R.id.tapAbv); + final TextView ibuText = ButterKnife.findById(mView, R.id.tapIbu); final TextView tapNotes = ButterKnife.findById(mView, R.id.tapNotes); final ViewFlipper flipper = ButterKnife.findById(mView, R.id.tapStatusFlipper); @@ -256,6 +258,21 @@ public void onClick(View v) { description = tap.getDescription(); } + // Find ABV and IBU values + final String abv = String.valueOf(keg.getBeverage().getAbvPercent()); + if(keg.getBeverage().getAbvPercent() == 0 && !mCore.getConfiguration().getAbvVisibleWhenZero()) { + abvText.setVisibility(View.GONE); + } else { + abvText.setText(abv + "% ABV"); + } + + final String ibu = String.valueOf(Math.round(keg.getBeverage().getIbu())); + if(keg.getBeverage().getIbu() == 0 && !mCore.getConfiguration().getIbuVisibleWhenZero()){ + ibuText.setVisibility(View.GONE); + } else{ + ibuText.setText(ibu + " IBUs"); + } + final ImageView tapImage = (ImageView) mView.findViewById(R.id.tapImage); final ImageView tapIllustration = (ImageView) mView.findViewById(R.id.tapIllustration); @@ -291,14 +308,15 @@ public void onClick(View v) { final Image image = keg.getBeverage().getPicture(); final String imageUrl = image.getUrl(); mImageDownloader.download(imageUrl, tapImage); - } else if (!Strings.isNullOrEmpty(description)) { - tapImage.setVisibility(View.GONE); + } + + showIllustration(!keg.getBeverage().hasPicture()); + + if (!Strings.isNullOrEmpty(description) && mCore.getConfiguration().getDisplayTapNotes()) { tapNotes.setVisibility(View.VISIBLE); tapNotes.setText(description); } - showIllustration(true); - // TODO(mikey): proper units support // Badge 1: Pints Poured final BadgeView badge1 = (BadgeView) mView.findViewById(R.id.tapStatsBadge1); diff --git a/kegtab/src/main/java/org/kegbot/app/config/AppConfiguration.java b/kegtab/src/main/java/org/kegbot/app/config/AppConfiguration.java index c317a6a8..e0e6358d 100644 --- a/kegtab/src/main/java/org/kegbot/app/config/AppConfiguration.java +++ b/kegtab/src/main/java/org/kegbot/app/config/AppConfiguration.java @@ -294,6 +294,18 @@ public boolean getTemperaturesCelsius() { return getBoolean(ConfigKey.TEMPERATURE_UNITS_CELSIUS); } + public boolean getAbvVisibleWhenZero() { + return getBoolean(ConfigKey.ABV_DISPLAY_WHEN_ZERO); + } + + public boolean getIbuVisibleWhenZero() { + return getBoolean(ConfigKey.IBU_DISPLAY_WHEN_ZERO); + } + + public boolean getDisplayTapNotes() { + return getBoolean(ConfigKey.DISPLAY_TAP_NOTES); + } + public boolean stayAwake() { return getBoolean(ConfigKey.STAY_AWAKE); } diff --git a/kegtab/src/main/java/org/kegbot/app/config/ConfigKey.java b/kegtab/src/main/java/org/kegbot/app/config/ConfigKey.java index b0dc588a..5aa20334 100644 --- a/kegtab/src/main/java/org/kegbot/app/config/ConfigKey.java +++ b/kegtab/src/main/java/org/kegbot/app/config/ConfigKey.java @@ -64,6 +64,11 @@ enum ConfigKey { VOLUME_UNITS_METRIC(FALSE), TEMPERATURE_UNITS_CELSIUS(FALSE), + ABV_DISPLAY_WHEN_ZERO(FALSE), + IBU_DISPLAY_WHEN_ZERO(FALSE), + + DISPLAY_TAP_NOTES(TRUE), + STAY_AWAKE(TRUE), KEEP_SCREEN_ON(TRUE), WAKE_DURING_POUR(FALSE), diff --git a/kegtab/src/main/res/layout/pour_in_progress_activity.xml b/kegtab/src/main/res/layout/pour_in_progress_activity.xml index a10a765b..7b0312d5 100644 --- a/kegtab/src/main/res/layout/pour_in_progress_activity.xml +++ b/kegtab/src/main/res/layout/pour_in_progress_activity.xml @@ -38,7 +38,7 @@ - - - + - + \ No newline at end of file diff --git a/kegtab/src/main/res/layout/tap_detail.xml b/kegtab/src/main/res/layout/tap_detail.xml index 3ea8e4e6..1e1754a3 100644 --- a/kegtab/src/main/res/layout/tap_detail.xml +++ b/kegtab/src/main/res/layout/tap_detail.xml @@ -38,6 +38,18 @@ android:layout_toRightOf="@+id/tapTitle" android:layout_alignBaseline="@+id/tapTitle"/> + + + + + + - - - - \ No newline at end of file + diff --git a/kegtab/src/main/res/values-sw700dp/styles.xml b/kegtab/src/main/res/values-sw700dp/styles.xml index cf114154..8749f226 100644 --- a/kegtab/src/main/res/values-sw700dp/styles.xml +++ b/kegtab/src/main/res/values-sw700dp/styles.xml @@ -88,7 +88,7 @@ + +