[PTX] Remove demoting comments

Author: Keluaa

src/cleanup/ptx.jl

@@ -12,6 +12,7 @@ Accepted `cleanup_opts` and their default values:
  - `demangle=true`: demangle names within the code
  - `keep_loop_comments=false`: keep loop comments generated by the LLVM backend
  - `keep_block_comments=false`: keep code block comments generated by the LLVM backend
+ - `keep_demoting_comments=false`: keep variable demoting comments generated by the LLVM backend
  - `indent_calls=true`: re-indent `call` instructions to be more recognizable and readable
  - `align_preds=8`: align instruction guards (e.g. `@p1`) such that the instruction is placed at the n-th column.
 """
@@ -39,6 +40,13 @@ function cleanup_code(::Val{:ptx}, c, dbinfo, cleanup_opts)
             r"^\/\/ %.+\R"m => "",  # when the whole line is a comment like such, remove the newline as well
         )
     end
+    if !get(cleanup_opts, :keep_demoting_comments, false)
+        # Those comments indicate that a variable type was demoted to a smaller/more generic one.
+        push!(extra_patterns,
+            r"^\/\/ .+? has been demoted\R"m => "",
+            r"^\s*\/\/ demoted variable\R"m => "",
+        )
+    end
     if (align_preds = get(cleanup_opts, :align_preds, 8); align_preds > 0)
         # Align guard predicates such that the beginning of the instruction is at the
         # `align_preds`-th column.

src/cleanup/sass.jl

@@ -34,5 +34,5 @@ function cleanup_code(::Val{:sass}, c, dbinfo, cleanup_opts)
     c = replace(c, extra_patterns...)
 
     # SASS output uses 8 spaces as indent, but there is still some tabs in some places.
-    return replace(c, replace_tabs(8))    
+    return replace(c, replace_tabs(8))
 end

test/cleanup.jl

@@ -200,6 +200,8 @@ end
         @test is_removed("// -- Begin function", ptx_sample, cleaned_ptx)
         @test is_removed("// -- End function", ptx_sample, cleaned_ptx)
         @test is_removed(r"// %L\d+", ptx_sample, cleaned_ptx)
+        @test is_removed("// shmem has been demoted", ptx_sample, cleaned_ptx)
+        @test is_removed("// demoted variable", ptx_sample, cleaned_ptx)
 
         # Demangling
         @test is_removed("14gpu_reverse_ka", ptx_sample, cleaned_ptx)
@@ -355,7 +357,8 @@ end
 end
 
 
-# TODO
-@testset "AGX" begin end
+@testset "AGX" begin
+    # TODO
+end
 
 end