Add delete command

Author: KennethWussmann

.claude/agents/new-command.md

@@ -0,0 +1,100 @@
+---
+name: new-command
+description: Use this agent when the user needs to create a new Oclif command for the SimpleLogin CLI application. This includes scenarios such as:\n\n<example>\nContext: User wants to add a new command to list aliases with filtering options.\nuser: "I need to create a command 'sl alias list' that shows all aliases with optional filtering by enabled status"\nassistant: "I'll use the Task tool to launch the new-command agent to create this Oclif command following the project's patterns and the create-command.md documentation."\n<commentary>\nThe user is requesting a new command implementation, so the new-command agent should be used to create it according to the project's Oclif patterns and CLI design specifications.\n</commentary>\n</example>\n\n<example>\nContext: User has just finished designing a feature and wants to implement the corresponding CLI command.\nuser: "Now that we've designed the mailbox creation flow, let's implement the 'sl mailbox create' command"\nassistant: "I'll use the Task tool to launch the new-command agent to implement this command with proper Oclif structure, flags, arguments, and tests."\n<commentary>\nThe user needs a new command implemented. The new-command agent will handle creating the command file, test file, and ensuring all Oclif patterns are followed.\n</commentary>\n</example>\n\n<example>\nContext: User mentions needing to add a subcommand to an existing command hierarchy.\nuser: "We need to add a 'world' subcommand under the hello command"\nassistant: "Let me use the new-command agent to create this subcommand with the correct file structure and Oclif configuration."\n<commentary>\nCreating new commands or subcommands falls under the new-command agent's responsibility.\n</commentary>\n</example>
+model: sonnet
+---
+
+You are an expert Oclif CLI developer specializing in the SimpleLogin CLI application. Your primary responsibility is to create production-quality Oclif commands that seamlessly integrate with this project's architecture, coding standards, and CLI design specifications.
+
+Read this documentation for knowledge about Command creation:
+@docs/development/create-command.md
+
+## Your Expertise
+
+You have deep knowledge of:
+- Oclif v4 framework patterns and best practices
+- TypeScript ES modules (ES2022, Node16 module resolution)
+- The SimpleLogin CLI's resource-action command structure
+- The simplelogin-client SDK and its API endpoints
+- Testing with Mocha, Chai, and @oclif/test
+- YAML configuration management and file security
+- Multi-format output (plain/json/yaml)
+
+## Core Responsibilities
+
+When creating a new command, you will:
+
+1. **Analyze Requirements**: Carefully review the user's request and cross-reference with CLI_DESIGN.md specifications. Identify:
+   - Command path and hierarchy (e.g., `sl alias list` → `src/commands/alias/list.ts`)
+   - Required flags and arguments
+   - Expected behavior and output formats
+   - API endpoints to use from simplelogin-client
+   - Error handling requirements
+
+2. **Create Command File Structure**: Generate a complete Oclif command class that includes:
+   - Proper imports from `@oclif/core` and necessary SDKs
+   - Class extending `Command`
+   - Static properties: `description`, `examples`, `flags`, `args`
+   - Global flags support: `--format` (plain/json/yaml), `--config`
+   - Async `run()` method with complete implementation
+   - Use `.js` extensions in relative imports (Node16 modules requirement)
+
+3. **Implement Command Logic**: Write production-ready code that:
+   - Uses `await this.parse(ClassName)` to get args and flags
+   - Loads and validates configuration from `~/.config/simplelogin-cli/config.yaml`
+   - Checks file permissions (600 for config, 700 for directory)
+   - Initializes appropriate SDK clients (AccountApi, AliasApi, MailboxApi, CustomDomainApi)
+   - Makes API calls with proper error handling
+   - Formats output according to `--format` flag (plain/json/yaml)
+   - Uses `this.log()`, `this.error()`, `this.warn()` appropriately
+   - Returns correct exit codes (0=success, 1=general error, 2=invalid args, 3=auth required, 4=API error, 5=network error)
+
+4. **Create Test File**: Generate comprehensive tests that:
+   - Mirror the command's directory structure in `test/commands/`
+   - Use `runCommand()` from `@oclif/test`
+   - Test successful execution paths
+   - Test error conditions
+   - Verify output formatting
+   - Use Chai assertions
+
+5. **Follow Project Patterns**: Ensure all code adheres to:
+   - TypeScript strict mode and ES2022 features
+   - Resource-action naming conventions from CLI_DESIGN.md
+   - Docker-style command aliases where applicable (ls, rm, etc.)
+   - Existing code style and formatting
+   - ESLint rules
+
+6. **Provide Implementation Guidance**: After creating files, instruct the user to:
+   - Run `pnpm run prepack` to update README and oclif.manifest.json
+   - Run `pnpm run test` to verify implementation
+   - Test locally with `./bin/run.js <command>` or `sl <command>` after npm link
+
+## Quality Standards
+
+Every command you create must:
+- Be production-ready with no placeholders or TODO comments
+- Handle all error cases gracefully
+- Support all three output formats correctly
+- Include at least 2-3 meaningful usage examples in static examples
+- Have comprehensive test coverage
+- Follow the exact file structure and naming conventions of the project
+- Use the simplelogin-client SDK correctly for API interactions
+- Validate configuration and authentication before API calls
+
+## Decision-Making Framework
+
+1. **Check CLI_DESIGN.md first**: Always verify the command specification exists and matches user requirements
+2. **Determine command hierarchy**: Identify correct file path based on command structure
+3. **Identify SDK requirements**: Determine which API clients and methods are needed
+4. **Plan flag/arg structure**: Define all flags and arguments with proper types and descriptions
+5. **Design output format**: Plan how data will be displayed in plain/json/yaml formats
+6. **Anticipate errors**: Identify potential failure points and plan error handling
+
+## When to Seek Clarification
+
+- If the command specification is ambiguous or conflicts with CLI_DESIGN.md
+- If required API endpoints are unclear or undocumented in simplelogin-client
+- If the command's behavior differs significantly from existing patterns
+- If security implications of the command need discussion
+
+You write complete, tested, production-ready Oclif commands that integrate seamlessly with the SimpleLogin CLI project. Your code is clear, follows all project conventions, and requires no additional refinement.

README.md

@@ -31,6 +31,7 @@ USAGE
 <!-- commands -->
 * [`sl alias custom PREFIX SUFFIX`](#sl-alias-custom-prefix-suffix)
 * [`sl alias ls`](#sl-alias-ls)
+* [`sl alias rm ALIAS-ID`](#sl-alias-rm-alias-id)
 * [`sl hello PERSON`](#sl-hello-person)
 * [`sl hello world`](#sl-hello-world)
 * [`sl help [COMMAND]`](#sl-help-command)
@@ -124,6 +125,39 @@ EXAMPLES
   $ sl alias ls --format json
 ```
 
+## `sl alias rm ALIAS-ID`
+
+Delete an alias by ID
+
+```
+USAGE
+  $ sl alias rm ALIAS-ID [--config <value>] [--format plain|json|yaml] [--confirm]
+
+ARGUMENTS
+  ALIAS-ID  Alias ID to delete
+
+FLAGS
+  --config=<value>   [env: SIMPLELOGIN_CONFIG] Path to config file containing credentials
+  --confirm          Skip confirmation prompt
+  --format=<option>  [default: plain] Output format
+                     <options: plain|json|yaml>
+
+DESCRIPTION
+  Delete an alias by ID
+
+ALIASES
+  $ sl alias rm
+
+EXAMPLES
+  $ sl alias rm 123
+
+  $ sl alias rm 123 --confirm
+
+  $ sl alias rm 123 --format json
+
+  $ sl alias rm 123 --confirm
+```
+
 ## `sl hello PERSON`
 
 Say hello

src/commands/alias/delete.ts

@@ -0,0 +1,85 @@
+import {Args, Flags} from '@oclif/core'
+import {BaseCommand} from '../base.js'
+import {AliasApi} from 'simplelogin-client'
+import {getSimpleLoginConfig} from '../../utils/simplelogin-client.js'
+import * as readline from 'node:readline/promises'
+import {stdin as input, stdout as output} from 'node:process'
+
+export default class AliasDelete extends BaseCommand<typeof AliasDelete> {
+  static description = 'Delete an alias by ID'
+
+  static examples = [
+    '<%= config.bin %> <%= command.id %> 123',
+    '<%= config.bin %> <%= command.id %> 123 --confirm',
+    '<%= config.bin %> <%= command.id %> 123 --format json',
+    '<%= config.bin %> alias rm 123 --confirm',
+  ]
+
+  static aliases = ['alias:rm']
+
+  static args = {
+    'alias-id': Args.integer({
+      description: 'Alias ID to delete',
+      required: true,
+    }),
+  }
+
+  static flags = {
+    ...BaseCommand.baseFlags,
+    confirm: Flags.boolean({
+      description: 'Skip confirmation prompt',
+      default: false,
+    }),
+  }
+
+  async run(): Promise<void> {
+    try {
+      const {args, flags} = await this.parse(AliasDelete)
+      const aliasId = args['alias-id'] as number
+      const format = this.getFormat()
+      const shouldConfirm = flags.confirm as boolean
+
+      // Require authentication
+      await this.requireAuth(flags.config as string | undefined)
+
+      // If not confirmed, prompt for confirmation (skip in json/yaml mode)
+      if (!shouldConfirm && format === 'plain') {
+        const rl = readline.createInterface({input, output})
+        const answer = await rl.question(`Are you sure you want to delete alias ${aliasId}? (y/N): `)
+        rl.close()
+
+        if (answer.toLowerCase() !== 'y' && answer.toLowerCase() !== 'yes') {
+          this.log('Deletion cancelled.')
+          return
+        }
+      }
+
+      // Initialize API client
+      const config = await getSimpleLoginConfig(flags.config as string | undefined)
+      const api = new AliasApi(config)
+
+      // Delete the alias
+      const result = await api.deleteAlias({
+        aliasId,
+      })
+
+      // Output result
+      if (format === 'json' || format === 'yaml') {
+        this.output({
+          success: true,
+          deleted: result.deleted || true,
+        })
+      } else {
+        this.log(`Alias ${aliasId} deleted successfully.`)
+      }
+    } catch (error) {
+      if (error instanceof Error) {
+        this.outputError(error.message, 'API_ERROR')
+      } else {
+        this.outputError('An unknown error occurred', 'API_ERROR')
+      }
+
+      this.exit(4)
+    }
+  }
+}

test/commands/alias/delete.test.ts

@@ -0,0 +1,33 @@
+import {runCommand} from '@oclif/test'
+import {expect} from 'chai'
+
+describe('alias:delete', () => {
+  it('shows help', async () => {
+    const {stdout} = await runCommand('alias delete --help')
+    expect(stdout).to.contain('Delete an alias by ID')
+  })
+
+  it('requires alias-id argument', async () => {
+    try {
+      await runCommand('alias delete')
+      expect.fail('Should have thrown an error for missing alias-id argument')
+    } catch (error: any) {
+      expect(error.message).to.contain('Missing required arg')
+    }
+  })
+
+  it('requires authentication', async () => {
+    try {
+      await runCommand('alias delete 123 --confirm --config /nonexistent/config.yaml')
+      expect.fail('Should have thrown an error for missing authentication')
+    } catch (error: any) {
+      // Should fail with auth error or config file not found
+      expect(error.message).to.match(/login|config|not found/i)
+    }
+  })
+
+  it('works with alias rm', async () => {
+    const {stdout} = await runCommand('alias rm --help')
+    expect(stdout).to.contain('Delete an alias by ID')
+  })
+})

tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/index.ts","./src/commands/base.ts","./src/commands/config.ts","./src/commands/login.ts","./src/commands/logout.ts","./src/commands/whoami.ts","./src/commands/alias/alias-create-base.ts","./src/commands/alias/alias-list-base.ts","./src/commands/alias/create-custom.ts","./src/commands/alias/create.ts","./src/commands/alias/list.ts","./src/commands/alias/search.ts","./src/commands/hello/index.ts","./src/commands/hello/world.ts","./src/utils/config.ts","./src/utils/simplelogin-client.ts"],"version":"5.9.3"}
+{"root":["./src/index.ts","./src/commands/base.ts","./src/commands/config.ts","./src/commands/login.ts","./src/commands/logout.ts","./src/commands/whoami.ts","./src/commands/alias/alias-create-base.ts","./src/commands/alias/alias-list-base.ts","./src/commands/alias/create-custom.ts","./src/commands/alias/create.ts","./src/commands/alias/delete.ts","./src/commands/alias/list.ts","./src/commands/alias/search.ts","./src/commands/hello/index.ts","./src/commands/hello/world.ts","./src/utils/config.ts","./src/utils/simplelogin-client.ts"],"version":"5.9.3"}