refac: make update workpsaces function take the WorkspaceMetadata tupe for the old workspace

Author: Keshav-writes-code

apps/app/src/components/general/workspace_selector/index.svelte

@@ -65,10 +65,10 @@
                       }
                     : undefined;
 
-                  await init_or_update_workspace(
-                    workspace_root_path.data?.path,
-                    { path, recent_filenode_path }
-                  );
+                  await init_or_update_workspace(workspace_root_path.data, {
+                    path,
+                    recent_filenode_path,
+                  });
                 }}
                 class="
                 {workspace_root_path.data?.path == path.path && 'bg-base-100'}
@@ -121,14 +121,15 @@
             onclick={async () => {
               const path = await show_folder_picker();
 
+              // Update the prevous workspace
               const recent_filenode_path = opened_filenode.data
                 ? {
                     path: opened_filenode.data.path,
                     document_top_tree_uri: null,
                   }
                 : undefined;
 
-              await init_or_update_workspace(workspace_root_path.data?.path, {
+              await init_or_update_workspace(workspace_root_path.data, {
                 path,
                 recent_filenode_path,
               });
@@ -148,13 +149,10 @@
                       }
                     : undefined;
 
-                  await init_or_update_workspace(
-                    workspace_root_path.data?.path,
-                    {
-                      path,
-                      recent_filenode_path,
-                    }
-                  );
+                  await init_or_update_workspace(workspace_root_path.data, {
+                    path,
+                    recent_filenode_path,
+                  });
                 }}
               >
                 <div class="size-6 i-tabler:folder-open"></div>

apps/app/src/lib/operations/workspace/operations.svelte.ts

@@ -21,17 +21,19 @@ import {
   persistent_states,
   type WorkspaceMetadata,
 } from '@/lib/states/persistent/index.svelte';
+import type { GenericPath } from '@/lib/types';
 
 // NOTE: Mainly updates only the UI States of the App
 export async function init_or_update_workspace(
-  old_workspace_root_path: string | undefined,
+  old_workspace: GenericPath | undefined,
   new_workspace: Omit<WorkspaceMetadata, 'last_accessed'>
 ) {
   try {
     // Prerequisites
     workspace_picker_dialog_open_state.data = false;
     const { path: workspace_path, recent_filenode_path } = new_workspace;
-    if (old_workspace_root_path === workspace_path.path) return;
+    if (old_workspace?.path === workspace_path.path) return;
+    console.log('Passed the return');
     reset_ui_states();
 
     // Actual Workspace Updation