Revert "Migrate file tree creation to Rust backend"#11
Merged
Keshav-writes-code merged 1 commit intodevfrom Dec 19, 2025
Merged
Conversation
This reverts commit a86faf2.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #6, which had migrated file tree creation from a TypeScript/JavaScript implementation to a Rust backend. The revert restores the original JavaScript-based file tree building logic and removes the Rust implementation.
Key changes:
- Restored TypeScript file tree building functions (
build_file_tree_from_fs,transform_entries_to_filenode,transform_android_entries_to_filenode) - Removed Rust file tree implementation and the
build_file_treeTauri command - Cleaned up unused Rust dependencies (
urlencodingandfutures)
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
apps/app/src/lib/file_tree/builder.ts |
Restored complete TypeScript file tree building implementation with platform-specific logic for Android and desktop |
apps/app/src/lib/file_tree/utils/file_tree_utils.ts |
Removed blank lines (whitespace cleanup) |
apps/app/src/components/sidebar/file_manager/items_renderer.svelte |
Minor whitespace change on class attribute |
apps/app/src/components/sidebar/file_manager/index.svelte |
Removed blank line (whitespace cleanup) |
apps/app/src-tauri/src/lib.rs |
Removed entire Rust file tree implementation including FileNode struct, recursive building functions, and Tauri command handler |
apps/app/src-tauri/Cargo.toml |
Removed urlencoding and futures dependencies no longer needed |
apps/app/src-tauri/Cargo.lock |
Updated lock file to reflect removed direct dependencies (transitive dependencies remain) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ondragend={reset_dnd} | ||
| oncontextmenu={(e) => handle_node_right_click(e, node)} | ||
| class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''} | ||
| class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''} |
There was a problem hiding this comment.
This line has trailing whitespace at the end. Please remove the trailing space after the closing double quote on this line.
Suggested change
| class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''} | |
| class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6