Skip to content

Revert "Migrate file tree creation to Rust backend"#11

Merged
Keshav-writes-code merged 1 commit intodevfrom
revert-6-migrate-filetree-to-rust-7043552137559722624
Dec 19, 2025
Merged

Revert "Migrate file tree creation to Rust backend"#11
Keshav-writes-code merged 1 commit intodevfrom
revert-6-migrate-filetree-to-rust-7043552137559722624

Conversation

@Keshav-writes-code
Copy link
Copy Markdown
Owner

Reverts #6

@Keshav-writes-code Keshav-writes-code marked this pull request as ready for review December 19, 2025 16:05
Copilot AI review requested due to automatic review settings December 19, 2025 16:05
@Keshav-writes-code Keshav-writes-code merged commit 46652f6 into dev Dec 19, 2025
7 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts PR #6, which had migrated file tree creation from a TypeScript/JavaScript implementation to a Rust backend. The revert restores the original JavaScript-based file tree building logic and removes the Rust implementation.

Key changes:

  • Restored TypeScript file tree building functions (build_file_tree_from_fs, transform_entries_to_filenode, transform_android_entries_to_filenode)
  • Removed Rust file tree implementation and the build_file_tree Tauri command
  • Cleaned up unused Rust dependencies (urlencoding and futures)

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/app/src/lib/file_tree/builder.ts Restored complete TypeScript file tree building implementation with platform-specific logic for Android and desktop
apps/app/src/lib/file_tree/utils/file_tree_utils.ts Removed blank lines (whitespace cleanup)
apps/app/src/components/sidebar/file_manager/items_renderer.svelte Minor whitespace change on class attribute
apps/app/src/components/sidebar/file_manager/index.svelte Removed blank line (whitespace cleanup)
apps/app/src-tauri/src/lib.rs Removed entire Rust file tree implementation including FileNode struct, recursive building functions, and Tauri command handler
apps/app/src-tauri/Cargo.toml Removed urlencoding and futures dependencies no longer needed
apps/app/src-tauri/Cargo.lock Updated lock file to reflect removed direct dependencies (transitive dependencies remain)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ondragend={reset_dnd}
oncontextmenu={(e) => handle_node_right_click(e, node)}
class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''}
class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''}
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has trailing whitespace at the end. Please remove the trailing space after the closing double quote on this line.

Suggested change
class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''}
class="{opened_filenode?.path === node.path ? 'bg-base-content/10' : ''}

Copilot uses AI. Check for mistakes.
@Keshav-writes-code Keshav-writes-code deleted the revert-6-migrate-filetree-to-rust-7043552137559722624 branch December 19, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants