Merge pull request #305 from sebastiangl/main

add support for iOS isInspectable property vis webSettings

Author: KevinnZou

sample/shared/src/commonMain/kotlin/com/kevinnzou/sample/BasicWebViewSample.kt

@@ -19,7 +19,6 @@ import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.ArrowBack
 import androidx.compose.material.icons.filled.Close
 import androidx.compose.runtime.Composable
-import androidx.compose.runtime.DisposableEffect
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
@@ -54,16 +53,13 @@ import kotlinx.coroutines.flow.filter
 @Composable
 internal fun BasicWebViewSample(navHostController: NavHostController? = null) {
     val initialUrl = "https://github.com/KevinnZou/compose-webview-multiplatform"
-    val state = rememberWebViewState(url = initialUrl)
-    DisposableEffect(Unit) {
-        state.webSettings.apply {
+    val state =
+        rememberWebViewState(url = initialUrl) {
             logSeverity = KLogSeverity.Debug
             customUserAgentString =
                 "Mozilla/5.0 (Macintosh; Intel Mac OS X 11_1) AppleWebKit/625.20 (KHTML, like Gecko) Version/14.3.43 Safari/625.20"
+            iOSWebSettings.isInspectable = true
         }
-
-        onDispose { }
-    }
     val navigator = rememberWebViewNavigator()
     var textFieldValue by remember(state.lastLoadedUrl) {
         mutableStateOf(state.lastLoadedUrl)

webview/src/commonMain/kotlin/com/multiplatform/webview/setting/PlatformWebSettings.kt

@@ -251,5 +251,9 @@ sealed class PlatformWebSettings {
          * Whether a user gesture is required to play media. The default is {@code true}.
          */
         var mediaPlaybackRequiresUserGesture: Boolean = true,
+        /**
+         * Whether the WebView supports inspection via MacOS Safari. The default value is {@code false}.
+         */
+        var isInspectable: Boolean = false,
     ) : PlatformWebSettings()
 }

webview/src/commonMain/kotlin/com/multiplatform/webview/web/WebViewState.kt

@@ -110,6 +110,7 @@ class WebViewState(webContent: WebContent) {
 fun rememberWebViewState(
     url: String,
     additionalHttpHeaders: Map<String, String> = emptyMap(),
+    extraSettings: WebSettings.() -> Unit = {},
 ): WebViewState =
 // Rather than using .apply {} here we will recreate the state, this prevents
     // a recomposition loop when the webview updates the url itself.
@@ -126,6 +127,7 @@ fun rememberWebViewState(
                 url = url,
                 additionalHttpHeaders = additionalHttpHeaders,
             )
+        extraSettings(this.webSettings)
     }
 
 /**

webview/src/iosMain/kotlin/com/multiplatform/webview/web/WebView.ios.kt

@@ -141,6 +141,8 @@ fun IOSWebView(
                         showsVerticalScrollIndicator = it.showVerticalScrollIndicator
                     }
                 }
+
+                this.setInspectable(state.webSettings.iOSWebSettings.isInspectable)
             }.also {
                 val iosWebView = IOSWebView(it, scope, webViewJsBridge)
                 state.webView = iosWebView