fix: P1-P3 improvements — OAuth, sync, enrollment, retry, integration tests, Makefile refactor#3
Merged
Conversation
…ed check, renewal window, retry logic, IDisposable, GroupNumber config, nested product response model
…ested product response format
… add lifecycle test, make empty-account resilient
…Acceptance and DCV findings
… generate-order-149-fresh, probe-endpoints, get-field-details targets
…findings from sandbox exploration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[ThreadStatic]OAuth pattern withCERTInextOAuthAuthenticator : AuthenticatorBase— bearer token now injected per-requestblockingBuffer.CompleteAdding()infinallyblock inSynchronize— sync stream now terminates correctlyPing()now checks_config.Enabledand returns early when disabledDomainName,SignerName,SignerPlace,SignerIptoGetTemplateParameterAnnotations()— these were in the manifest but invisible in the Command UIRenewalWindowDayssemantics to Option A — renew only when cert expires within the next N days, not "unless expired >N days ago"ExecuteWithRetryAsync— 3 attempts on 5xx/network errors, immediate return on 4xxCERTInextClientnow implementsIDisposable; disposesRestClientandSemaphoreSlimGetProductDetailsAsyncnow passes it — fixes empty product list on accounts that require itGetProductDetailsResponsedeserialization — API returns nested category envelope (productDetails[].products[]), not a flat listTests
CompleteAdding,Pingdisabled, renewal window semantics, retry logic)LifecycleTests(enroll → sync → revoke), all empty-account tests skip gracefullyMakefile / scripts
scripts/scripts/lib/certinext-auth.shgenerate-order-149-fresh,probe-endpoints,get-field-details,list-cas,create-productAnalysis docs
analysis/certinext-caplugin/postman-api-findings.md— sandbox API findings: product codes (global per environment, not per-account),AgreementAcceptanceendpoint, DCV numeric method codes, product management API confirmed absentTest plan
dotnet test certinext-caplugin.sln— all 104 unit tests passdotnet test CERTInext.IntegrationTests/— 4 pass, 4 skip (fresh sandbox account; lifecycle test unblocked once product 149 auto-approval is enabled in the portal)make ping— ValidateCredentials succeedsmake get-product-details-group— returns full product listmake orders— returns order report