chore: apply copilot feedback

Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>

Author: irby

.github/workflows/test.yml

@@ -31,9 +31,7 @@ jobs:
       # Build Go binary
       - run: go build -v cmd/main.go
 
-      # Compile test packages without running them to warm the build cache.
-      # The test job restores this cache and only needs to execute the binaries.
-      - run: go test -run=^$ ./...
+      - run: go test ./...
 
   lint:
     name: Lint

Makefile

@@ -222,7 +222,7 @@ $(GOLANGCI_LINT): $(LOCALBIN)
 	@[ -f $(GOLANGCI_LINT) ] || { \
 	set -e; \
 	echo "Downloading golangci-lint $(GOLANGCI_LINT_VERSION)" ;\
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b $(LOCALBIN) $(GOLANGCI_LINT_VERSION) ;\
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/$(GOLANGCI_LINT_VERSION)/install.sh | sh -s -- -b $(LOCALBIN) $(GOLANGCI_LINT_VERSION) ;\
 	mv $(LOCALBIN)/golangci-lint $(GOLANGCI_LINT) ;\
 	}
 

internal/command/client.go

@@ -18,6 +18,7 @@ package command
 
 import (
 	"fmt"
+	"io"
 	"net/http"
 	"strings"
 	"time"
@@ -69,7 +70,8 @@ type clientAdapter struct {
 func (c *clientAdapter) GetAllMetadataFields(r v1.ApiGetMetadataFieldsRequest) ([]v1.CSSCMSDataModelModelsMetadataType, error) {
 	fields, resp, err := c.getAllMetadataFields(r)
 	if resp != nil && resp.Body != nil {
-		resp.Body.Close()
+		_, _ = io.Copy(io.Discard, resp.Body)
+		_ = resp.Body.Close()
 	}
 	return fields, err
 }

policy/roles.rego

@@ -1,5 +1,7 @@
 package main
 
+import rego.v1
+
 # Roles are namespace-scoped resources. A Role without a namespace will be
 # silently defaulted by the API server, which can result in permissions being
 # granted in an unintended namespace. Require every Role to declare its

policy/serviceaccounts.rego

@@ -1,5 +1,7 @@
 package main
 
+import rego.v1
+
 # ServiceAccounts are namespace-scoped resources. A ServiceAccount without a namespace will be
 # silently defaulted by the API server, which can result in permissions being
 # granted in an unintended namespace. Require every ServiceAccount to declare its