Skip to content

Commit 4da801f

Browse files
committed
add logging for enrollments
1 parent 65aacba commit 4da801f

2 files changed

Lines changed: 14 additions & 8 deletions

File tree

digicert-certcentral-caplugin/CertCentralCAPlugin.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,11 @@ public async Task<EnrollmentResult> Enroll(string csr, string subject, Dictionar
6060
{
6161
_logger.MethodEntry(LogLevel.Trace);
6262

63-
_logger.LogDebug($"Enrolling for certificate with subject {subject}");
64-
foreach (var sanlist in san)
65-
{
66-
string sans = string.Join(",", sanlist.Value);
67-
_logger.LogDebug($"SANs type \"{sanlist.Key}\": {sans}");
68-
}
63+
string sans = string.Join(";", san.Select(s => string.Format("{0}:{1}", s.Key, string.Join(",", s.Value))));
64+
string paramsList = string.Join(";", productInfo.ProductParameters.Select(x => string.Format("{0}={1}", x.Key, x.Value)));
65+
_logger.LogTrace($"Attempting to enroll for certificate with:\nSubject: {subject}\nSANs: {sans}\nParams: {paramsList}\nCSR: {csr}");
66+
67+
6968

7069
OrderResponse orderResponse = new OrderResponse();
7170
CertCentralCertType certType = CertCentralCertType.GetAllTypes(_config).FirstOrDefault(x => x.ProductCode.Equals(productInfo.ProductID));

digicert-certcentral-caplugin/Client/CertCentralClient.cs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,11 @@ public ListMetadataResponse ListMetadata(ListMetadataRequest request)
295295

296296
public OrderResponse OrderCertificate(OrderRequest request)
297297
{
298-
CertCentralResponse response = Request(request, JsonConvert.SerializeObject(request, Formatting.None, new JsonSerializerSettings { NullValueHandling = NullValueHandling.Ignore }));
298+
string jsonRequest = JsonConvert.SerializeObject(request, Formatting.None, new JsonSerializerSettings { NullValueHandling = NullValueHandling.Ignore });
299+
300+
Logger.LogTrace($"Order request:\n{jsonRequest}");
301+
302+
CertCentralResponse response = Request(request, jsonRequest);
299303

300304
OrderResponse orderResponse = new OrderResponse();
301305
if (!response.Success)
@@ -312,7 +316,10 @@ public OrderResponse OrderCertificate(OrderRequest request)
312316

313317
public OrderResponse ReissueCertificate(ReissueRequest request)
314318
{
315-
CertCentralResponse response = Request(request, JsonConvert.SerializeObject(request, Formatting.None, new JsonSerializerSettings { NullValueHandling = NullValueHandling.Ignore }));
319+
string jsonRequest = JsonConvert.SerializeObject(request, Formatting.None, new JsonSerializerSettings { NullValueHandling = NullValueHandling.Ignore });
320+
Logger.LogTrace($"Reissue request:\n{jsonRequest}");
321+
322+
CertCentralResponse response = Request(request, jsonRequest);
316323

317324
OrderResponse reissueResponse = new OrderResponse();
318325
if (!response.Success)

0 commit comments

Comments
 (0)