-
Notifications
You must be signed in to change notification settings - Fork 0
Dev 2.1 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev 2.1 #32
Changes from all commits
52eee75
70fe240
f9e1564
516d230
844a7e1
b0819c4
db730d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -106,9 +106,10 @@ An API Key within your Digicert account that has the necessary permissions to en | |||||
| * **Organization-Name** - OPTIONAL: For requests that will not have a subject (such as ACME) you can use this field to provide the organization name. Value supplied here will override any CSR values, so do not include this field if you want the organization from the CSR to be used. | ||||||
| * **RenewalWindowDays** - OPTIONAL: The number of days from certificate expiration that the gateway should do a renewal rather than a reissue. If not provided, default is 90. | ||||||
| * **CertType** - OPTIONAL: The type of cert to enroll for. Valid values are 'ssl' and 'client'. The value provided here must be consistant with the ProductID. If not provided, default is 'ssl'. Ignored for secure_email_* product types. | ||||||
| * **IncludeClientAuthEKU** - OPTIONAL for SSL certs, ignored otherwise. If set to 'true', SSL certs enrolled under this template will have the Client Authentication EKU added to the request. NOTE: This feature is currently planned to be removed by DigiCert in May 2026. | ||||||
| * **EnrollDivisionId** - OPTIONAL: The division (container) ID to use for enrollments against this template. | ||||||
| * **CommonNameIndicator** - Required for secure_email_sponsor and secure_email_organization products, ignored otherwise. Defines the source of the common name. Valid values are: email_address, given_name_surname, pseudonym, organization_name | ||||||
| * **ProfileType** - Optional for secure_email_* types, ignored otherwise. Valid values are: strict, multipurpose. Default value is strict. | ||||||
| * **ProfileType** - Optional for secure_email_* types, ignored otherwise. Valid values are: strict, multipurpose. Use 'multipurpose' if your cert includes any additional EKUs such as client auth. Default if not provided is dependent on product configuration within Digicert portal. | ||||||
|
||||||
| * **ProfileType** - Optional for secure_email_* types, ignored otherwise. Valid values are: strict, multipurpose. Use 'multipurpose' if your cert includes any additional EKUs such as client auth. Default if not provided is dependent on product configuration within Digicert portal. | |
| * **ProfileType** - Optional for secure_email_* types, ignored otherwise. Valid values are: strict, multipurpose. Use 'multipurpose' if your cert includes any additional EKUs such as client auth. Default if not provided is dependent on product configuration within DigiCert portal. |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -294,6 +294,12 @@ | |||||||||||||||||||
| string priorCertSnString = null; | ||||||||||||||||||||
| string priorCertReqID = null; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| if (typeOfCert.Equals("ssl") && Convert.ToBoolean(productInfo.ProductParameters[CertCentralConstants.Config.INCLUDE_CLIENT_AUTH])) | ||||||||||||||||||||
| { | ||||||||||||||||||||
|
Comment on lines
+297
to
+298
|
||||||||||||||||||||
| if (typeOfCert.Equals("ssl") && Convert.ToBoolean(productInfo.ProductParameters[CertCentralConstants.Config.INCLUDE_CLIENT_AUTH])) | |
| { | |
| bool includeClientAuth = false; | |
| if (productInfo.ProductParameters.TryGetValue(CertCentralConstants.Config.INCLUDE_CLIENT_AUTH, out var includeClientAuthValue) && !string.IsNullOrEmpty(includeClientAuthValue)) | |
| { | |
| includeClientAuth = Convert.ToBoolean(includeClientAuthValue); | |
| } | |
| if (string.Equals(typeOfCert, "ssl", StringComparison.OrdinalIgnoreCase) && includeClientAuth) | |
| { |
Copilot
AI
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the magic string for the profile option; define a named constant (e.g., CertCentralConstants.ProfileOptions.ServerClientAuthEku) to prevent typos and ease reuse.
| orderRequest.Certificate.ProfileOption = "server_client_auth_eku"; | |
| orderRequest.Certificate.ProfileOption = CertCentralConstants.ProfileOptions.ServerClientAuthEku; |
Check warning on line 500 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 500 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-generate-readme-workflow / Use private doctool action in public repository
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 500 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 500 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 504 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 504 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Copilot
AI
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardize vendor capitalization to 'DigiCert'.
| Comments = "Optional for secure_email_* types, ignored otherwise. Valid values are: strict, multipurpose. Use 'multipurpose' if your cert includes any additional EKUs such as client auth. Default if not provided is dependent on product configuration within Digicert portal.", | |
| Comments = "Optional for secure_email_* types, ignored otherwise. Valid values are: strict, multipurpose. Use 'multipurpose' if your cert includes any additional EKUs such as client auth. Default if not provided is dependent on product configuration within DigiCert portal.", |
Check warning on line 657 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 657 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-generate-readme-workflow / Use private doctool action in public repository
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 657 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 657 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 661 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 661 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 699 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 699 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-generate-readme-workflow / Use private doctool action in public repository
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 699 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 699 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 703 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 703 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 759 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 759 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-generate-readme-workflow / Use private doctool action in public repository
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 759 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 759 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 763 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 763 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 929 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 929 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-generate-readme-workflow / Use private doctool action in public repository
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 929 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 929 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 933 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 933 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 1000 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 1000 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-generate-readme-workflow / Use private doctool action in public repository
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 1000 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 1000 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 1004 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check warning on line 1004 in digicert-certcentral-caplugin/CertCentralCAPlugin.cs
GitHub Actions / call-starter-workflow / call-dotnet-build-and-release-workflow / dotnet-build-and-release
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardize vendor capitalization to 'DigiCert'.