Skip to content

Commit a21ef53

Browse files
fixed sans issue passed to extension data
1 parent 12f5461 commit a21ef53

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,3 +352,4 @@ healthchecksdb
352352
logs
353353
*.pem
354354
*.crt
355+
.claude/settings.local.json

GCPCAS/Client/CreateCertificateRequestBuilder.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
Copyright © 2025 Keyfactor
2+
Copyright 2025 Keyfactor
33
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
@@ -85,12 +85,14 @@ public ICreateCertificateRequestBuilder WithEnrollmentProductInfo(EnrollmentProd
8585
string base64Value = param.Value;
8686

8787
_logger.LogTrace($"Loggin oid and value {oid} {base64Value}");
88-
89-
var extension = CreateX509Extension(oid, base64Value);
90-
if (extension != null)
88+
if (oid != "2.5.29.17") //can't send Sans as an extension to google, they do not like this and you will get an error
9189
{
92-
_logger.LogTrace($"Adding Extension");
93-
_additionalExtensions.Add(extension);
90+
var extension = CreateX509Extension(oid, base64Value);
91+
if (extension != null)
92+
{
93+
_logger.LogTrace($"Adding Extension");
94+
_additionalExtensions.Add(extension);
95+
}
9496
}
9597
}
9698
}

0 commit comments

Comments
 (0)