Skip to content

Commit ffc3923

Browse files
indrorabhillkeyfactorKeyfactor
authored
Merge 1.3.2 to main (#24)
* chore: Update integration-manifest.json (#16) * Update integration-manifest.json * Update generated docs --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * release: 1.3.0 --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * fixed sans issue passed to extension data (#23) * fixed sans issue passed to extension data * fixed change log --------- Co-authored-by: Morgan Gangwere <470584+indrora@users.noreply.github.com> --------- Co-authored-by: Brian Hill <76450501+bhillkeyfactor@users.noreply.github.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
1 parent 1f2bc14 commit ffc3923

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
- 1.3.2
2+
- Fixed Sans Being passed through Extensions Data, Google does not like this.
3+
- 1.3.1
14
- 1.3.0
25
- SaaS containerization changes with Google Credentials
36
- 1.2.2

GCPCAS/Client/CreateCertificateRequestBuilder.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
Copyright © 2025 Keyfactor
2+
Copyright 2025 Keyfactor
33
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
@@ -85,12 +85,14 @@ public ICreateCertificateRequestBuilder WithEnrollmentProductInfo(EnrollmentProd
8585
string base64Value = param.Value;
8686

8787
_logger.LogTrace($"Loggin oid and value {oid} {base64Value}");
88-
89-
var extension = CreateX509Extension(oid, base64Value);
90-
if (extension != null)
88+
if (oid != "2.5.29.17") //can't send Sans as an extension to google, they do not like this and you will get an error
9189
{
92-
_logger.LogTrace($"Adding Extension");
93-
_additionalExtensions.Add(extension);
90+
var extension = CreateX509Extension(oid, base64Value);
91+
if (extension != null)
92+
{
93+
_logger.LogTrace($"Adding Extension");
94+
_additionalExtensions.Add(extension);
95+
}
9496
}
9597
}
9698
}

0 commit comments

Comments
 (0)