Skip to content

Commit 3966d4d

Browse files
leefine02KeyfactorLee Fine
authored
Release: 2.2
--------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> Co-authored-by: Lee Fine <lfine@keyfactor.com>
1 parent 8be34dd commit 3966d4d

4 files changed

Lines changed: 190 additions & 107 deletions

File tree

.github/workflows/keyfactor-starter-workflow.yml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,17 @@ on:
1111

1212
jobs:
1313
call-starter-workflow:
14-
uses: keyfactor/actions/.github/workflows/starter.yml@3.1.2
14+
uses: keyfactor/actions/.github/workflows/starter.yml@v4
15+
with:
16+
command_token_url: ${{ vars.COMMAND_TOKEN_URL }} # Only required for doctool generated screenshots
17+
command_hostname: ${{ vars.COMMAND_HOSTNAME }} # Only required for doctool generated screenshots
18+
command_base_api_path: ${{ vars.COMMAND_API_PATH }} # Only required for doctool generated screenshots
1519
secrets:
16-
token: ${{ secrets.V2BUILDTOKEN}}
17-
APPROVE_README_PUSH: ${{ secrets.APPROVE_README_PUSH}}
18-
gpg_key: ${{ secrets.KF_GPG_PRIVATE_KEY }}
19-
gpg_pass: ${{ secrets.KF_GPG_PASSPHRASE }}
20-
scan_token: ${{ secrets.SAST_TOKEN }}
20+
token: ${{ secrets.V2BUILDTOKEN}} # REQUIRED
21+
gpg_key: ${{ secrets.KF_GPG_PRIVATE_KEY }} # Only required for golang builds
22+
gpg_pass: ${{ secrets.KF_GPG_PASSPHRASE }} # Only required for golang builds
23+
scan_token: ${{ secrets.SAST_TOKEN }} # REQUIRED
24+
entra_username: ${{ secrets.DOCTOOL_ENTRA_USERNAME }} # Only required for doctool generated screenshots
25+
entra_password: ${{ secrets.DOCTOOL_ENTRA_PASSWD }} # Only required for doctool generated screenshots
26+
command_client_id: ${{ secrets.COMMAND_CLIENT_ID }} # Only required for doctool generated screenshots
27+
command_client_secret: ${{ secrets.COMMAND_CLIENT_SECRET }} # Only required for doctool generated screenshots

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
v2.2.1
2+
- Bug Fix: Truncate long alias names to build temporary alias name when replacing a certificate to avoid error when going over max 63 character limit
3+
14
v2.2.0
25
- Update to generate dual build for .net6/.net8 configurations
36
- Update to use doctool for README generation.

GCPLoadBalancer/GCPStore.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ public class GCPStore
4747
private const int OPERATION_MAX_WAIT_MILLISECONDS = 300000;
4848
private const int OPERATION_INTERVAL_WAIT_MILLISECONDS = 5000;
4949
private const string OPERATION_DONE = "DONE";
50+
private const string TEMP_ALIAS_SUFFIX = "-temp";
51+
private const int MAX_ALIAS_LENGTH = 63;
5052

5153
public GCPStore(string storePath, Dictionary<string, string> storeProperties)
5254
{
@@ -62,7 +64,7 @@ public GCPStore(string storePath, Dictionary<string, string> storeProperties)
6264
public void insert(SslCertificate sslCertificate, bool overwrite)
6365
{
6466
string alias = sslCertificate.Name;
65-
string tempAlias = alias + "-temp";
67+
string tempAlias = CreateTempAlias(alias);
6668
string targetCertificateSelfLink = string.Empty;
6769
string tempCertificateSelfLink = string.Empty;
6870

@@ -491,5 +493,10 @@ private void SetProjectAndRegion(string storePath)
491493
region = projectRegion[1];
492494
}
493495
}
496+
497+
private string CreateTempAlias(string alias)
498+
{
499+
return MAX_ALIAS_LENGTH - TEMP_ALIAS_SUFFIX.Length >= alias.Length ? alias + TEMP_ALIAS_SUFFIX : alias.Substring(0, MAX_ALIAS_LENGTH - TEMP_ALIAS_SUFFIX.Length) + TEMP_ALIAS_SUFFIX;
500+
}
494501
}
495502
}

0 commit comments

Comments
 (0)