Ab#81657

.github/workflows/keyfactor-starter-workflow.yml

@@ -11,10 +11,17 @@ on:
 
 jobs:
   call-starter-workflow:
-    uses: keyfactor/actions/.github/workflows/starter.yml@3.1.2
+    uses: keyfactor/actions/.github/workflows/starter.yml@v4
+    with:
+      command_token_url: ${{ vars.COMMAND_TOKEN_URL }} # Only required for doctool generated screenshots
+      command_hostname: ${{ vars.COMMAND_HOSTNAME }} # Only required for doctool generated screenshots
+      command_base_api_path: ${{ vars.COMMAND_API_PATH }} # Only required for doctool generated screenshots
     secrets:
-      token: ${{ secrets.V2BUILDTOKEN}}
-      APPROVE_README_PUSH: ${{ secrets.APPROVE_README_PUSH}}
-      gpg_key: ${{ secrets.KF_GPG_PRIVATE_KEY }}
-      gpg_pass: ${{ secrets.KF_GPG_PASSPHRASE }}
-      scan_token: ${{ secrets.SAST_TOKEN }}
+      token: ${{ secrets.V2BUILDTOKEN}} # REQUIRED
+      gpg_key: ${{ secrets.KF_GPG_PRIVATE_KEY }} # Only required for golang builds
+      gpg_pass: ${{ secrets.KF_GPG_PASSPHRASE }} # Only required for golang builds
+      scan_token: ${{ secrets.SAST_TOKEN }} # REQUIRED
+      entra_username: ${{ secrets.DOCTOOL_ENTRA_USERNAME }} # Only required for doctool generated screenshots
+      entra_password: ${{ secrets.DOCTOOL_ENTRA_PASSWD }} # Only required for doctool generated screenshots
+      command_client_id: ${{ secrets.COMMAND_CLIENT_ID }} # Only required for doctool generated screenshots
+      command_client_secret: ${{ secrets.COMMAND_CLIENT_SECRET }} # Only required for doctool generated screenshots

CHANGELOG.md

@@ -1,3 +1,6 @@
+v2.2.1
+- Bug Fix: Truncate long alias names to build temporary alias name when replacing a certificate to avoid error when going over max 63 character limit
+
 v2.2.0
 - Update to generate dual build for .net6/.net8 configurations
 - Update to use doctool for README generation.

GCPLoadBalancer/GCPStore.cs

@@ -47,6 +47,8 @@
         private const int OPERATION_MAX_WAIT_MILLISECONDS = 300000;
         private const int OPERATION_INTERVAL_WAIT_MILLISECONDS = 5000;
         private const string OPERATION_DONE = "DONE";
+        private const string TEMP_ALIAS_SUFFIX = "-temp";
+        private const int MAX_ALIAS_LENGTH = 63;
 
         public GCPStore(string storePath, Dictionary<string, string> storeProperties)
         {
@@ -62,7 +64,7 @@
         public void insert(SslCertificate sslCertificate, bool overwrite)
         {
             string alias = sslCertificate.Name;
-            string tempAlias = alias + "-temp";
+            string tempAlias = CreateTempAlias(alias);
             string targetCertificateSelfLink = string.Empty;
             string tempCertificateSelfLink = string.Empty;
 
@@ -75,7 +77,7 @@
                 catch (Google.GoogleApiException ex)
                 {
                     if (ex.HttpStatusCode != System.Net.HttpStatusCode.NotFound)
                         throw ex;
                 }
 
                 //SCENARIO => certificate alias exists, but overwrite flag not set.  ERROR
@@ -104,7 +106,7 @@
                 catch (Google.GoogleApiException ex)
                 {
                     if (ex.HttpStatusCode != System.Net.HttpStatusCode.NotFound)
                         throw ex;
                 }
 
                 //SCENARIO => Overwrite flag set.  Neither the passed in alias nor the temporary alias exists, so no clean up from a previous job is necessary.  No
@@ -132,7 +134,7 @@
                         catch (Google.GoogleApiException ex)
                         {
                             if (ex.HttpStatusCode != System.Net.HttpStatusCode.NotFound)
                                 throw ex;
                         }
                     }
 
@@ -173,7 +175,7 @@
             {
                 logger.LogError("Error adding or binding certificate: " + ex.Message);
                 logger.LogDebug(ex.StackTrace);
                 throw ex;
             }
         }
 
@@ -491,5 +493,10 @@
                 region = projectRegion[1];
             }
         }
+
+        private string CreateTempAlias(string alias)
+        {
+            return MAX_ALIAS_LENGTH - TEMP_ALIAS_SUFFIX.Length >= alias.Length ? alias + TEMP_ALIAS_SUFFIX : alias.Substring(0, MAX_ALIAS_LENGTH - TEMP_ALIAS_SUFFIX.Length) + TEMP_ALIAS_SUFFIX;
+        }
     }
 }