updated CSR enrollment to use Keyfactor Client SDK

[joevanwanzeeleKF]

• Updated the Hashicorp SDK libraries
• Incorporated the Keyfactor GO SDK for authentication and interaction with the Command API

[Copilot]

Pull Request Overview

This PR updates the HashiCorp Vault secrets engine to use the Keyfactor GO SDK v24 for authentication and API interactions, replacing the previous custom HTTP client implementation. The changes modernize the integration by leveraging the official SDK for better maintainability and feature support.

• Updated dependencies including HashiCorp SDK libraries and Go toolchain to version 1.24
• Replaced custom HTTP client code with Keyfactor GO SDK v24 API calls
• Improved error handling and logging throughout the codebase

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
go.mod	Updated Go version to 1.24 and added Keyfactor GO SDK v24 dependency
client.go	Refactored client creation to use Keyfactor SDK instead of custom HTTP client
cert_util.go	Replaced manual HTTP requests with SDK API calls for certificate operations
path_certs.go	Updated certificate revocation to use SDK and improved JSON validation
backend.go	Modified backend to use SDK client type and added plugin version
path_revoke.go	Removed commented-out revocation code
cmd/keyfactor/main.go	Updated to use ServeMultiplex for plugin serving
fields.go	Fixed documentation reference from alt_names to dns_sans
README.md, readme_source.md, installation.txt	Added clarifying notes about CA certificate requirements
CHANGELOG.md	Added entry for version 1.4.2

Comments suppressed due to low confidence (3)

go.mod:3

• Go version 1.24.0 does not exist. The latest stable Go version as of my knowledge cutoff is 1.23.x. Please use a valid Go version like 1.23.3.

go 1.24.0

go.mod:5

• Go toolchain version 1.24.3 does not exist. Please use a valid Go toolchain version that corresponds to an actual Go release.

toolchain go1.24.3

cert_util.go:540

• Variable name 'keyfactorId' should follow Go naming conventions and be 'keyfactorID' (with uppercase 'ID').

		return []string{}, fmt.Errorf("error decoding base64 string: %w", err)

[Copilot]

The operation type should be logical.UpdateOperation or logical.CreateOperation for revoke endpoints. logical.RevokeOperation is typically used for lease revocation, not certificate revocation endpoints.

Suggested change

logical.RevokeOperation: b.pathRevokeCert,

[Copilot]

The error message format string contains '{{err}}' but uses %w verb style. It should be either fmt.Errorf("unable to store certificate locally: %w", err) or use a different format.

Suggested change

	return nil, "", fmt.Errorf("unable to store certificate locally: {{err}}", err)
	return nil, "", fmt.Errorf("unable to store certificate locally: %w", err)

[Copilot]

The error message format string contains '{{err}}' but uses %w verb style. It should be either fmt.Errorf("unable to store the keyfactor ID for the certificate locally: %w", err) or use a different format.

Suggested change

	return nil, "", fmt.Errorf("unable to store the keyfactor ID for the certificate locally: {{err}}", err)
	return nil, "", fmt.Errorf("unable to store the keyfactor ID for the certificate locally: %w", err)