Merge pull request #279 from Keyfactor/vmware_store_types

spbsoluble · web-flow · commit 6b307945c85d · 2025-08-14T09:49:45.000-07:00
vCenter store type definition
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# v1.8.3
+
+## Chores
+
+- `store-types`: Add `vCenter` store type and update internal definitions to latest from Keyfactor GitHub repos.
+
 # v1.8.2
 
 ## Fixes
diff --git a/cmd/store_types.json b/cmd/store_types.json
@@ -2868,8 +2868,8 @@
     "ShortName": "HPiLO",
     "Capability": "HPiLO",
     "LocalStore": false,
-    "StorePathDescription": "Path points to the HPiLO instance address, IP or domain name.",
-    "ClientMachineDescription": "Runs on a Windows based machine.",
+    "StorePathDescription": "This should contain the path pointing to the HPiLO instance address, IP or domain name.",
+    "ClientMachineDescription": "Should contain a copy of the store path for compatibility reasons but is currently unused.",
     "SupportedOperations": {
       "Add": true,
       "Create": false,
@@ -2882,27 +2882,46 @@
         "Name": "InventoryAll",
         "DisplayName": "InventoryAll",
         "Type": "Bool",
+        "DependsOn": null,
         "DefaultValue": "false",
         "Required": true,
-        "Description": "Allows for inventory of factory-installed certificates: `Platform Cert`,`SystemIAK`,`SystemIDevID`, `iLOIDevID/BMCIDevIDPCA`"
+        "Description": "If true, allows for inventory of additional factory-installed certificates and their chains: `Platform Cert`,`SystemIAK`,`SystemIDevID`, `iLOIDevID/BMCIDevIDPCA`"
       },
       {
         "Name": "IgnoreValidation",
         "DisplayName": "IgnoreValidation",
         "Type": "Bool",
-        "DefaultValue": "true",
+        "DefaultValue": "false",
+        "DependsOn": null,
         "Required": true,
-        "Description": "WARNING: Only enable if testing. Used to disable certificate validation checks at the API endpoint."
+        "Description": "WARNING: Only enable if testing. Used to disable certificate validation checks at the API endpoint. Should be set to false in any production scenario."
       },
       {
         "Name": "HTTPSCertWaitTime",
         "DisplayName": "HTTPS Cert Wait Time",
         "Type": "String",
         "DefaultValue": "60",
+        "DependsOn": null,
         "Required": true,
         "Description": "The HPiLO API requires the user to wait while the HTTPS Cert CSR is generated. HP suggests a time of 60 seconds, as is the default setting, but it can be adjusted."
       }
     ],
+    "EntryParameters": [
+      {
+        "Name": "IncludeIP",
+        "DisplayName": "IncludeIP",
+        "Type": "Bool",
+        "RequiredWhen": {
+          "HasPrivateKey": false,
+          "OnAdd": false,
+          "OnRemove": false,
+          "OnReenrollment": true
+        },
+        "DependsOn": "",
+        "DefaultValue": "false",
+        "Description": "Enables the addition of the device IP as a SAN to the CSR during reenrollment. Used particularly during HTTPSCert reenrollment, where it can be set as desired, and should be set to false during all other operations."
+      }
+    ],
     "PasswordOptions": {
       "EntrySupported": true,
       "StoreRequired": false,
@@ -2912,7 +2931,7 @@
     "ServerRequired": true,
     "PowerShell": false,
     "BlueprintAllowed": false,
-    "CustomAliasAllowed": "Forbidden"
+    "CustomAliasAllowed": "Optional"
   },
   {
     "Name": "IIS Bound Certificate",
@@ -4992,5 +5011,56 @@
     "PowerShell": false,
     "BlueprintAllowed": true,
     "CustomAliasAllowed": "Forbidden"
+  },
+  {
+    "Name": "VMware vCenter",
+    "ShortName": "vCenter",
+    "Capability": "vCenter",
+    "LocalStore": false,
+    "ServerRequired": true,
+    "PowerShell": false,
+    "BlueprintAllowed": true,
+    "StorePathType": "",
+    "StorePathValue": "",
+    "CustomAliasAllowed": "Optional",
+    "ClientMachineDescription": "The domain name of the vSphere client managing vCenter (url to vCenter host without the 'https://'.",
+    "StorePathDescription": "A unique identifier for this store.  The actual value is unused by the orchestrator extension",
+    "PasswordOptions": {
+      "EntrySupported": false,
+      "StoreRequired": false,
+      "Style": "Default"
+    },
+    "SupportedOperations": {
+      "Add": true,
+      "Create": false,
+      "Discovery": false,
+      "Enrollment": false,
+      "Remove": true
+    },
+    "EntryParameters": [],
+    "JobProperties": [],
+    "PrivateKeyAllowed": "Optional",
+    "Properties": [
+      {
+        "Name": "ServerUsername",
+        "DisplayName": "Server Username",
+        "Type": "Secret",
+        "DependsOn": "",
+        "DefaultValue": "",
+        "Required": true,
+        "IsPamEligable": false,
+        "Description": "The vCenter username used to manage the vCenter connection"
+      },
+      {
+        "Name": "ServerPassword",
+        "DisplayName": "Server Password",
+        "Type": "Secret",
+        "DependsOn": "",
+        "DefaultValue": "",
+        "Required": true,
+        "IsPamEligable": false,
+        "Description": "The secret vCenter password used to manage the vCenter connection"
+      }
+    ]
   }
 ]
diff --git a/pkg/version/version.go b/pkg/version/version.go
@@ -15,7 +15,7 @@
 package version
 
 var (
-	VERSION    = "1.8.2"
-	BUILD_DATE = "2025-07-31"
+	VERSION    = "1.8.3"
+	BUILD_DATE = "2025-08-14"
 	COMMIT     = "HEAD"
 )
diff --git a/store_types.json b/store_types.json
@@ -2868,8 +2868,8 @@
     "ShortName": "HPiLO",
     "Capability": "HPiLO",
     "LocalStore": false,
-    "StorePathDescription": "Path points to the HPiLO instance address, IP or domain name.",
-    "ClientMachineDescription": "Runs on a Windows based machine.",
+    "StorePathDescription": "This should contain the path pointing to the HPiLO instance address, IP or domain name.",
+    "ClientMachineDescription": "Should contain a copy of the store path for compatibility reasons but is currently unused.",
     "SupportedOperations": {
       "Add": true,
       "Create": false,
@@ -2882,27 +2882,46 @@
         "Name": "InventoryAll",
         "DisplayName": "InventoryAll",
         "Type": "Bool",
+        "DependsOn": null,
         "DefaultValue": "false",
         "Required": true,
-        "Description": "Allows for inventory of factory-installed certificates: `Platform Cert`,`SystemIAK`,`SystemIDevID`, `iLOIDevID/BMCIDevIDPCA`"
+        "Description": "If true, allows for inventory of additional factory-installed certificates and their chains: `Platform Cert`,`SystemIAK`,`SystemIDevID`, `iLOIDevID/BMCIDevIDPCA`"
       },
       {
         "Name": "IgnoreValidation",
         "DisplayName": "IgnoreValidation",
         "Type": "Bool",
-        "DefaultValue": "true",
+        "DefaultValue": "false",
+        "DependsOn": null,
         "Required": true,
-        "Description": "WARNING: Only enable if testing. Used to disable certificate validation checks at the API endpoint."
+        "Description": "WARNING: Only enable if testing. Used to disable certificate validation checks at the API endpoint. Should be set to false in any production scenario."
       },
       {
         "Name": "HTTPSCertWaitTime",
         "DisplayName": "HTTPS Cert Wait Time",
         "Type": "String",
         "DefaultValue": "60",
+        "DependsOn": null,
         "Required": true,
         "Description": "The HPiLO API requires the user to wait while the HTTPS Cert CSR is generated. HP suggests a time of 60 seconds, as is the default setting, but it can be adjusted."
       }
     ],
+    "EntryParameters": [
+      {
+        "Name": "IncludeIP",
+        "DisplayName": "IncludeIP",
+        "Type": "Bool",
+        "RequiredWhen": {
+          "HasPrivateKey": false,
+          "OnAdd": false,
+          "OnRemove": false,
+          "OnReenrollment": true
+        },
+        "DependsOn": "",
+        "DefaultValue": "false",
+        "Description": "Enables the addition of the device IP as a SAN to the CSR during reenrollment. Used particularly during HTTPSCert reenrollment, where it can be set as desired, and should be set to false during all other operations."
+      }
+    ],
     "PasswordOptions": {
       "EntrySupported": true,
       "StoreRequired": false,
@@ -2912,7 +2931,7 @@
     "ServerRequired": true,
     "PowerShell": false,
     "BlueprintAllowed": false,
-    "CustomAliasAllowed": "Forbidden"
+    "CustomAliasAllowed": "Optional"
   },
   {
     "Name": "IIS Bound Certificate",
@@ -4992,5 +5011,56 @@
     "PowerShell": false,
     "BlueprintAllowed": true,
     "CustomAliasAllowed": "Forbidden"
+  },
+  {
+    "Name": "VMware vCenter",
+    "ShortName": "vCenter",
+    "Capability": "vCenter",
+    "LocalStore": false,
+    "ServerRequired": true,
+    "PowerShell": false,
+    "BlueprintAllowed": true,
+    "StorePathType": "",
+    "StorePathValue": "",
+    "CustomAliasAllowed": "Optional",
+    "ClientMachineDescription": "The domain name of the vSphere client managing vCenter (url to vCenter host without the 'https://'.",
+    "StorePathDescription": "A unique identifier for this store.  The actual value is unused by the orchestrator extension",
+    "PasswordOptions": {
+      "EntrySupported": false,
+      "StoreRequired": false,
+      "Style": "Default"
+    },
+    "SupportedOperations": {
+      "Add": true,
+      "Create": false,
+      "Discovery": false,
+      "Enrollment": false,
+      "Remove": true
+    },
+    "EntryParameters": [],
+    "JobProperties": [],
+    "PrivateKeyAllowed": "Optional",
+    "Properties": [
+      {
+        "Name": "ServerUsername",
+        "DisplayName": "Server Username",
+        "Type": "Secret",
+        "DependsOn": "",
+        "DefaultValue": "",
+        "Required": true,
+        "IsPamEligable": false,
+        "Description": "The vCenter username used to manage the vCenter connection"
+      },
+      {
+        "Name": "ServerPassword",
+        "DisplayName": "Server Password",
+        "Type": "Secret",
+        "DependsOn": "",
+        "DefaultValue": "",
+        "Required": true,
+        "IsPamEligable": false,
+        "Description": "The secret vCenter password used to manage the vCenter connection"
+      }
+    ]
   }
 ]

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`package version`
`16`	`16`
`17`	`17`	`var (`
`18`		`- VERSION = "1.8.2"`
`19`		`- BUILD_DATE = "2025-07-31"`
	`18`	`+ VERSION = "1.8.3"`
	`19`	`+ BUILD_DATE = "2025-08-14"`
`20`	`20`	`COMMIT = "HEAD"`
`21`	`21`	`)`