Skip to content

Commit bca04d8

Browse files
authored
Merge pull request #278 from Keyfactor/release-1.8
Release 1.8.2
2 parents 75c691e + dc49353 commit bca04d8

68 files changed

Lines changed: 1426 additions & 883 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/update-stores.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108

109109
- name: Save Store Types JSON Artifact
110110
if: success()
111-
uses: actions/upload-artifact@v3
111+
uses: actions/upload-artifact@v4
112112
with:
113113
name: store-types
114114
path: |
@@ -117,14 +117,14 @@ jobs:
117117
118118
- name: Save Invalid Store Types JSON Artifact
119119
if: success()
120-
uses: actions/upload-artifact@v3
120+
uses: actions/upload-artifact@v4
121121
with:
122122
name: invalid-repos
123123
path: ./tools/store-type-merge/invalid_repos.json
124124

125125
- name: Save logs directory
126126
if: success()
127-
uses: actions/upload-artifact@v3
127+
uses: actions/upload-artifact@v4
128128
with:
129129
name: logs
130130
path: ./tools/store-type-merge/log

CHANGELOG.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
# v1.8.2
2+
3+
## Fixes
4+
5+
### CLI
6+
7+
- Silence logging of initial `store-type` fetch
8+
- `store-types`: Update internal definitions to latest from Keyfactor GitHub repos.
9+
- `version` update internal version to `1.8.2`
10+
11+
### Chores
12+
13+
- `docs`: Add `migration` auto docs
14+
- `docs`: Refresh auto docs
15+
- `deps`: Update all deps to latest versions
16+
17+
118
# v1.8.1
219

320
## Fixes

cmd/helpers.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,10 @@ func informDebug(debugFlag bool) {
186186
if debugModeEnabled {
187187
//zerolog.SetGlobalLevel(zerolog.InfoLevel)
188188
zerolog.SetGlobalLevel(zerolog.DebugLevel)
189+
return
189190
}
191+
// Else no logs should be emitted
192+
zerolog.SetGlobalLevel(zerolog.Disabled)
190193
}
191194

192195
func initLogger() {
@@ -359,7 +362,7 @@ func outputResult(result interface{}, format string) {
359362
fmt.Println(fmt.Sprintf("%s", result))
360363
}
361364
log.Debug().
362-
Interface("result", result).
365+
Str("result", fmt.Sprintf("%s", result)).
363366
Str("format", format).
364367
Msg(fmt.Sprintf("%s outputResult", DebugFuncExit))
365368
}

cmd/storeTypes.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -636,10 +636,11 @@ func readStoreTypesConfig(fp, gitRef string, gitRepo string, offline bool) (map[
636636
}
637637

638638
func init() {
639-
offline = true // temporarily set to true as it runs before the flag is set
640-
debugFlag = false // temporarily set to false as it runs before the flag is set
639+
offline = true // temporarily set to true as it runs before the flag is set
641640
var gitRef string
642641
var gitRepo string
642+
643+
informDebug(false) // Do not output debug information for initial setup of store-types command
643644
validTypesString := strings.Join(getValidStoreTypes("", DefaultGitRef, DefaultGitRepo), ", ")
644645
offline = false //revert this so that flag is not set to true by default
645646
RootCmd.AddCommand(storeTypesCmd)

0 commit comments

Comments
 (0)