Skip to content

Commit 1275356

Browse files
author
Thierry RAMORASOAVINA
committed
Sklearn : rephrase error messages to be more precise
1 parent 8230bd4 commit 1275356

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

khiops/sklearn/estimators.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def _check_pair_parameters(estimator):
180180
if not isinstance(estimator.n_pairs, int):
181181
raise TypeError(type_error_message("n_pairs", estimator.n_pairs, int))
182182
if estimator.n_pairs < 0:
183-
raise ValueError("'n_pairs' must be positive")
183+
raise ValueError("'n_pairs' must be non-negative")
184184
if estimator.specific_pairs is not None:
185185
if not is_list_like(estimator.specific_pairs):
186186
raise TypeError(
@@ -955,7 +955,7 @@ def _simplify(
955955
type_error_message("'max_part_numbers' values", value, int)
956956
)
957957
elif value < 0:
958-
raise ValueError("'max_part_numbers' values must be positive")
958+
raise ValueError("'max_part_numbers' values must be non-negative")
959959
# Create temporary directory and tables
960960
computation_dir = self._create_computation_dir("simplify")
961961
output_dir = self._get_output_dir(computation_dir)
@@ -1272,17 +1272,17 @@ def _fit_check_params(self, ds, **kwargs):
12721272
if not isinstance(self.n_features, int):
12731273
raise TypeError(type_error_message("n_features", self.n_features, int))
12741274
if self.n_features < 0:
1275-
raise ValueError("'n_features' must be positive")
1275+
raise ValueError("'n_features' must be non-negative")
12761276
if not isinstance(self.n_trees, int):
12771277
raise TypeError(type_error_message("n_trees", self.n_trees, int))
12781278
if self.n_trees < 0:
1279-
raise ValueError("'n_trees' must be positive")
1279+
raise ValueError("'n_trees' must be non-negative")
12801280
if not isinstance(self.n_text_features, int):
12811281
raise TypeError(
12821282
type_error_message("n_text_features", self.n_text_features, int)
12831283
)
12841284
if self.n_text_features < 0:
1285-
raise ValueError("'n_text_features' must be positive")
1285+
raise ValueError("'n_text_features' must be non-negative")
12861286
if not isinstance(self.type_text_features, str):
12871287
raise TypeError(
12881288
type_error_message("type_text_features", self.type_text_features, str)
@@ -1307,7 +1307,7 @@ def _fit_check_params(self, ds, **kwargs):
13071307
type_error_message("n_feature_parts", self.n_feature_parts, int)
13081308
)
13091309
if self.n_feature_parts < 0:
1310-
raise ValueError("'n_feature_parts' must be positive")
1310+
raise ValueError("'n_feature_parts' must be non-negative")
13111311

13121312
def _fit_train_model(self, ds, computation_dir, **kwargs):
13131313
# Train the model with Khiops
@@ -1635,9 +1635,9 @@ def _fit_check_params(self, ds, **kwargs):
16351635

16361636
# Check estimator parameters
16371637
if self.n_evaluated_features < 0:
1638-
raise ValueError("'n_evaluated_features' must be positive")
1638+
raise ValueError("'n_evaluated_features' must be non-negative")
16391639
if self.n_selected_features < 0:
1640-
raise ValueError("'n_selected_features' must be positive")
1640+
raise ValueError("'n_selected_features' must be non-negative")
16411641

16421642

16431643
# Note: scikit-learn **requires** inherit first the mixins and then other classes

0 commit comments

Comments
 (0)