Skip to content

Commit 4dc0953

Browse files
author
Thierry RAMORASOAVINA
committed
Remove a useless skip condition against a conda env in test_remote_access.py
1 parent 267f7be commit 4dc0953

1 file changed

Lines changed: 0 additions & 24 deletions

File tree

tests/test_remote_access.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,6 @@ def remote_access_test_case(self):
140140
"""To be overridden by descendants"""
141141
return ""
142142

143-
def should_skip_in_a_conda_env(self):
144-
"""To be overridden by descendants"""
145-
return True
146-
147143
def print_test_title(self):
148144
print(f"\n Remote System: {self.remote_access_test_case()}")
149145

@@ -182,11 +178,6 @@ def setUp(self):
182178
KhiopsTestHelper.skip_expensive_test(self)
183179

184180
self.skip_if_no_config()
185-
if self.is_in_a_conda_env() and self.should_skip_in_a_conda_env():
186-
self.skipTest(
187-
f"Remote test case {self.remote_access_test_case()} "
188-
"in a conda environment is currently skipped"
189-
)
190181
self.print_test_title()
191182

192183
# Save the runner that can be modified by the test
@@ -354,11 +345,6 @@ def tearDownClass(cls):
354345
if s3_config_exists():
355346
kh.get_runner().__init__()
356347

357-
def should_skip_in_a_conda_env(self):
358-
# The S3 driver is now released for conda too.
359-
# No need to skip the tests any longer in a conda environment
360-
return False
361-
362348
def config_exists(self):
363349
return s3_config_exists()
364350

@@ -399,11 +385,6 @@ def tearDownClass(cls):
399385
if gcs_config_exists():
400386
kh.get_runner().__init__()
401387

402-
def should_skip_in_a_conda_env(self):
403-
# The GCS driver is now released for conda too.
404-
# No need to skip the tests any longer in a conda environment
405-
return False
406-
407388
def config_exists(self):
408389
return gcs_config_exists()
409390

@@ -586,11 +567,6 @@ def tearDownClass(cls):
586567
def config_exists(self):
587568
return docker_runner_config_exists()
588569

589-
def should_skip_in_a_conda_env(self):
590-
# Tests using a docker runner should never be skipped
591-
# even in a conda environment
592-
return False
593-
594570
def remote_access_test_case(self):
595571
return "KhiopsDockerRunner"
596572

0 commit comments

Comments
 (0)