Only allow setting .rule to a string representation of a rule (#475)

Author: popescu-v

khiops/core/dictionary.py

@@ -1187,7 +1187,7 @@ def __init__(self, json_data=None):
         self.structure_type = ""
 
         # Derivation rule
-        self.rule = ""
+        self._rule = ""
 
         # Metadata
         self.meta_data = MetaData()
@@ -1223,7 +1223,7 @@ def __init__(self, json_data=None):
             self.structure_type = json_data.get("structureType")
 
         # Initialize derivation rule
-        self.rule = json_data.get("rule", "")
+        self._rule = json_data.get("rule", "")
 
         # Initialize metadata
         json_meta_data = json_data.get("metaData")
@@ -1249,6 +1249,16 @@ def name(self, value):
         _check_name(value)
         self._name = value
 
+    @property
+    def rule(self):
+        return self._rule
+
+    @rule.setter
+    def rule(self, value):
+        if not is_string_like(value):
+            raise TypeError(type_error_message("rule", value, "string-like"))
+        self._rule = value
+
     def copy(self):
         """Copies this variable instance
 
@@ -1479,7 +1489,7 @@ def __init__(self, json_data=None):
         self.internal_comments = json_data.get("internalComments", [])
 
         # Initialize derivation rule
-        self.rule = json_data.get("rule", "")
+        self._rule = json_data.get("rule", "")
 
         # Initialize metadata if available
         json_meta_data = json_data.get("metaData")
@@ -1504,6 +1514,16 @@ def __str__(self):
         self.write(writer)
         return str(stream.getvalue(), encoding="utf8", errors="replace")
 
+    @property
+    def rule(self):
+        return self._rule
+
+    @rule.setter
+    def rule(self, value):
+        if not is_string_like(value):
+            raise TypeError(type_error_message("rule", value, "string-like"))
+        self._rule = value
+
     def add_variable(self, variable):
         """Adds a variable to this block
 

tests/test_core.py

@@ -1916,6 +1916,9 @@ def test_dictionary_accessors(self):
                     repr(dictionary.get_variable("fresh_one").get_rule()),
                     "Variable rule must be set correctly",
                 )
+                variable_rule = kh.Rule(verbatim="Ceil(Product(3, Random()))")
+                with self.assertRaises(TypeError):
+                    dictionary.get_variable("fresh_one").rule = variable_rule
 
                 # Test Dictionary variable block accessors
                 # Create a simple block
@@ -1959,7 +1962,9 @@ def test_dictionary_accessors(self):
 
                 # Set the block as non-native add, and remove it
                 dictionary_copy.add_variable_block(block)
-                block_rule = kh.Rule("SomeBlockCreatingRule()")
+                block_rule = kh.Rule("SomeBlockCreatingRule")
+                with self.assertRaises(TypeError):
+                    dictionary_copy.get_variable_block(block.name).rule = block_rule
                 dictionary_copy.get_variable_block(block.name).set_rule(block_rule)
                 self.assertEqual(block, dictionary_copy.get_variable_block(block.name))
                 removed_block = dictionary_copy.remove_variable_block(