Skip to content

Commit 84da6f1

Browse files
Rename transform_pairs parameter to transform_type_pairs
1 parent 1b730ee commit 84da6f1

File tree

5 files changed

+20
-18
lines changed

5 files changed

+20
-18
lines changed

doc/samples/samples_sklearn.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,7 @@ Samples
723723
keep_initial_variables=True,
724724
transform_type_categorical="part_id",
725725
transform_type_numerical="part_id",
726-
transform_pairs="part_id",
726+
transform_type_pairs="part_id",
727727
)
728728
khe.fit(X, y)
729729

khiops/samples/samples_sklearn.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,7 @@
865865
" keep_initial_variables=True,\n",
866866
" transform_type_categorical=\"part_id\",\n",
867867
" transform_type_numerical=\"part_id\",\n",
868-
" transform_pairs=\"part_id\",\n",
868+
" transform_type_pairs=\"part_id\",\n",
869869
")\n",
870870
"khe.fit(X, y)\n",
871871
"\n",

khiops/samples/samples_sklearn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ def khiops_encoder_with_hyperparameters():
761761
keep_initial_variables=True,
762762
transform_type_categorical="part_id",
763763
transform_type_numerical="part_id",
764-
transform_pairs="part_id",
764+
transform_type_pairs="part_id",
765765
)
766766
khe.fit(X, y)
767767

khiops/sklearn/estimators.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2731,7 +2731,7 @@ class KhiopsEncoder(TransformerMixin, KhiopsSupervisedEstimator):
27312731
27322732
See the documentation for the ``numerical_recoding_method`` parameter of the
27332733
`~.api.train_recoder` function for more details.
2734-
transform_pairs: str, default "part_id"
2734+
transform_type_pairs : str, default "part_id"
27352735
Type of transformation for bivariate features. Valid values:
27362736
- "part_id"
27372737
- "part_label"
@@ -2811,7 +2811,7 @@ def __init__(
28112811
keep_initial_variables=False,
28122812
transform_type_categorical="part_id",
28132813
transform_type_numerical="part_id",
2814-
transform_pairs="part_id",
2814+
transform_type_pairs="part_id",
28152815
verbose=False,
28162816
output_dir=None,
28172817
auto_sort=True,
@@ -2835,7 +2835,7 @@ def __init__(
28352835
self.group_target_value = group_target_value
28362836
self.transform_type_categorical = transform_type_categorical
28372837
self.transform_type_numerical = transform_type_numerical
2838-
self.transform_pairs = transform_pairs
2838+
self.transform_type_pairs = transform_type_pairs
28392839
self.informative_features_only = informative_features_only
28402840
self.keep_initial_variables = keep_initial_variables
28412841
self._khiops_model_prefix = "R_"
@@ -2892,12 +2892,12 @@ def _pairs_transform_method(self):
28922892
"conditional_info": "conditional info",
28932893
None: "none",
28942894
}
2895-
if self.transform_pairs not in _transform_types:
2895+
if self.transform_type_pairs not in _transform_types:
28962896
raise ValueError(
2897-
"'transform_pairs' must be one of the following:"
2897+
"'transform_type_pairs' must be one of the following:"
28982898
",".join(_transform_types.keys)
28992899
)
2900-
return _transform_types[self.transform_pairs]
2900+
return _transform_types[self.transform_type_pairs]
29012901

29022902
def _fit_check_params(self, ds, **kwargs):
29032903
# Call parent method
@@ -2931,10 +2931,12 @@ def _fit_check_params(self, ds, **kwargs):
29312931
"transform_type_categorical and transform_type_numerical "
29322932
"cannot be both None with n_trees == 0."
29332933
)
2934-
# Check 'transform_pairs' parameter
2935-
if not isinstance(self.transform_pairs, str):
2934+
# Check 'transform_type_pairs' parameter
2935+
if not isinstance(self.transform_type_pairs, str):
29362936
raise TypeError(
2937-
type_error_message("transform_pairs", self.transform_pairs, str)
2937+
type_error_message(
2938+
"transform_type_pairs", self.transform_type_pairs, str
2939+
)
29382940
)
29392941
self._pairs_transform_method() # Raises ValueError if invalid
29402942

@@ -3036,7 +3038,7 @@ def _fit_prepare_training_function_inputs(self, ds, computation_dir):
30363038

30373039
del kwargs["transform_type_categorical"]
30383040
del kwargs["transform_type_numerical"]
3039-
del kwargs["transform_pairs"]
3041+
del kwargs["transform_type_pairs"]
30403042
del kwargs["categorical_target"]
30413043

30423044
return args, kwargs

tests/test_sklearn.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2265,7 +2265,7 @@ def test_parameter_transfer_encoder_fit_from_monotable_dataframe(self):
22652265
"keep_initial_variables": False,
22662266
"transform_type_categorical": "part_id",
22672267
"transform_type_numerical": "part_id",
2268-
"transform_pairs": "part_id",
2268+
"transform_type_pairs": "part_id",
22692269
},
22702270
)
22712271

@@ -2289,7 +2289,7 @@ def test_parameter_transfer_encoder_fit_from_monotable_dataframe_with_df_y(
22892289
"keep_initial_variables": False,
22902290
"transform_type_categorical": "part_id",
22912291
"transform_type_numerical": "part_id",
2292-
"transform_pairs": "part_id",
2292+
"transform_type_pairs": "part_id",
22932293
},
22942294
)
22952295

@@ -2311,7 +2311,7 @@ def test_parameter_transfer_encoder_fit_from_monotable_file_dataset(self):
23112311
"keep_initial_variables": False,
23122312
"transform_type_categorical": "part_id",
23132313
"transform_type_numerical": "part_id",
2314-
"transform_pairs": "part_id",
2314+
"transform_type_pairs": "part_id",
23152315
},
23162316
)
23172317

@@ -2334,7 +2334,7 @@ def test_parameter_transfer_encoder_fit_from_multitable_dataframe(self):
23342334
"keep_initial_variables": False,
23352335
"transform_type_categorical": "part_id",
23362336
"transform_type_numerical": "part_id",
2337-
"transform_pairs": "part_id",
2337+
"transform_type_pairs": "part_id",
23382338
},
23392339
)
23402340

@@ -2357,7 +2357,7 @@ def test_parameter_transfer_encoder_fit_from_multitable_file_dataset(self):
23572357
"keep_initial_variables": False,
23582358
"transform_type_categorical": "part_id",
23592359
"transform_type_numerical": "part_id",
2360-
"transform_pairs": "part_id",
2360+
"transform_type_pairs": "part_id",
23612361
},
23622362
)
23632363

0 commit comments

Comments
 (0)