Skip to content

Commit 8efbf3b

Browse files
author
Thierry RAMORASOAVINA
committed
Remove a useless skip condition against a conda env in test_remote_access.py
1 parent 029409c commit 8efbf3b

1 file changed

Lines changed: 0 additions & 24 deletions

File tree

tests/test_remote_access.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,6 @@ def remote_access_test_case(self):
141141
"""To be overridden by descendants"""
142142
return ""
143143

144-
def should_skip_in_a_conda_env(self):
145-
"""To be overridden by descendants"""
146-
return True
147-
148144
def print_test_title(self):
149145
print(f"\n Remote System: {self.remote_access_test_case()}")
150146

@@ -183,11 +179,6 @@ def setUp(self):
183179
KhiopsTestHelper.skip_expensive_test(self)
184180

185181
self.skip_if_no_config()
186-
if self.is_in_a_conda_env() and self.should_skip_in_a_conda_env():
187-
self.skipTest(
188-
f"Remote test case {self.remote_access_test_case()} "
189-
"in a conda environment is currently skipped"
190-
)
191182
self.print_test_title()
192183

193184
# Save the runner that can be modified by the test
@@ -355,11 +346,6 @@ def tearDownClass(cls):
355346
if s3_config_exists():
356347
kh.get_runner().__init__()
357348

358-
def should_skip_in_a_conda_env(self):
359-
# The S3 driver is now released for conda too.
360-
# No need to skip the tests any longer in a conda environment
361-
return False
362-
363349
def config_exists(self):
364350
return s3_config_exists()
365351

@@ -400,11 +386,6 @@ def tearDownClass(cls):
400386
if gcs_config_exists():
401387
kh.get_runner().__init__()
402388

403-
def should_skip_in_a_conda_env(self):
404-
# The GCS driver is now released for conda too.
405-
# No need to skip the tests any longer in a conda environment
406-
return False
407-
408389
def config_exists(self):
409390
return gcs_config_exists()
410391

@@ -587,11 +568,6 @@ def tearDownClass(cls):
587568
def config_exists(self):
588569
return docker_runner_config_exists()
589570

590-
def should_skip_in_a_conda_env(self):
591-
# Tests using a docker runner should never be skipped
592-
# even in a conda environment
593-
return False
594-
595571
def remote_access_test_case(self):
596572
return "KhiopsDockerRunner"
597573

0 commit comments

Comments
 (0)