Skip to content

Commit be73e2e

Browse files
Rename transform_pairs parameter to transform_type_pairs
1 parent 733349b commit be73e2e

File tree

5 files changed

+20
-18
lines changed

5 files changed

+20
-18
lines changed

doc/samples/samples_sklearn.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,7 @@ Samples
725725
keep_initial_variables=True,
726726
transform_type_categorical="part_id",
727727
transform_type_numerical="part_id",
728-
transform_pairs="part_id",
728+
transform_type_pairs="part_id",
729729
)
730730
khe.fit(X, y)
731731

khiops/samples/samples_sklearn.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -867,7 +867,7 @@
867867
" keep_initial_variables=True,\n",
868868
" transform_type_categorical=\"part_id\",\n",
869869
" transform_type_numerical=\"part_id\",\n",
870-
" transform_pairs=\"part_id\",\n",
870+
" transform_type_pairs=\"part_id\",\n",
871871
")\n",
872872
"khe.fit(X, y)\n",
873873
"\n",

khiops/samples/samples_sklearn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,7 @@ def khiops_encoder_with_hyperparameters():
763763
keep_initial_variables=True,
764764
transform_type_categorical="part_id",
765765
transform_type_numerical="part_id",
766-
transform_pairs="part_id",
766+
transform_type_pairs="part_id",
767767
)
768768
khe.fit(X, y)
769769

khiops/sklearn/estimators.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2723,7 +2723,7 @@ class KhiopsEncoder(TransformerMixin, KhiopsSupervisedEstimator):
27232723
27242724
See the documentation for the ``numerical_recoding_method`` parameter of the
27252725
`~.api.train_recoder` function for more details.
2726-
transform_pairs: str, default "part_id"
2726+
transform_type_pairs : str, default "part_id"
27272727
Type of transformation for bivariate features. Valid values:
27282728
- "part_id"
27292729
- "part_label"
@@ -2803,7 +2803,7 @@ def __init__(
28032803
keep_initial_variables=False,
28042804
transform_type_categorical="part_id",
28052805
transform_type_numerical="part_id",
2806-
transform_pairs="part_id",
2806+
transform_type_pairs="part_id",
28072807
verbose=False,
28082808
output_dir=None,
28092809
auto_sort=True,
@@ -2827,7 +2827,7 @@ def __init__(
28272827
self.group_target_value = group_target_value
28282828
self.transform_type_categorical = transform_type_categorical
28292829
self.transform_type_numerical = transform_type_numerical
2830-
self.transform_pairs = transform_pairs
2830+
self.transform_type_pairs = transform_type_pairs
28312831
self.informative_features_only = informative_features_only
28322832
self.keep_initial_variables = keep_initial_variables
28332833
self._khiops_model_prefix = "R_"
@@ -2884,12 +2884,12 @@ def _pairs_transform_method(self):
28842884
"conditional_info": "conditional info",
28852885
None: "none",
28862886
}
2887-
if self.transform_pairs not in _transform_types:
2887+
if self.transform_type_pairs not in _transform_types:
28882888
raise ValueError(
2889-
"'transform_pairs' must be one of the following:"
2889+
"'transform_type_pairs' must be one of the following:"
28902890
",".join(_transform_types.keys)
28912891
)
2892-
return _transform_types[self.transform_pairs]
2892+
return _transform_types[self.transform_type_pairs]
28932893

28942894
def _fit_check_params(self, ds, **kwargs):
28952895
# Call parent method
@@ -2923,10 +2923,12 @@ def _fit_check_params(self, ds, **kwargs):
29232923
"transform_type_categorical and transform_type_numerical "
29242924
"cannot be both None with n_trees == 0."
29252925
)
2926-
# Check 'transform_pairs' parameter
2927-
if not isinstance(self.transform_pairs, str):
2926+
# Check 'transform_type_pairs' parameter
2927+
if not isinstance(self.transform_type_pairs, str):
29282928
raise TypeError(
2929-
type_error_message("transform_pairs", self.transform_pairs, str)
2929+
type_error_message(
2930+
"transform_type_pairs", self.transform_type_pairs, str
2931+
)
29302932
)
29312933
self._pairs_transform_method() # Raises ValueError if invalid
29322934

@@ -3028,7 +3030,7 @@ def _fit_prepare_training_function_inputs(self, ds, computation_dir):
30283030

30293031
del kwargs["transform_type_categorical"]
30303032
del kwargs["transform_type_numerical"]
3031-
del kwargs["transform_pairs"]
3033+
del kwargs["transform_type_pairs"]
30323034
del kwargs["categorical_target"]
30333035

30343036
return args, kwargs

tests/test_sklearn.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2265,7 +2265,7 @@ def test_parameter_transfer_encoder_fit_from_monotable_dataframe(self):
22652265
"keep_initial_variables": False,
22662266
"transform_type_categorical": "part_id",
22672267
"transform_type_numerical": "part_id",
2268-
"transform_pairs": "part_id",
2268+
"transform_type_pairs": "part_id",
22692269
},
22702270
)
22712271

@@ -2289,7 +2289,7 @@ def test_parameter_transfer_encoder_fit_from_monotable_dataframe_with_df_y(
22892289
"keep_initial_variables": False,
22902290
"transform_type_categorical": "part_id",
22912291
"transform_type_numerical": "part_id",
2292-
"transform_pairs": "part_id",
2292+
"transform_type_pairs": "part_id",
22932293
},
22942294
)
22952295

@@ -2311,7 +2311,7 @@ def test_parameter_transfer_encoder_fit_from_monotable_file_dataset(self):
23112311
"keep_initial_variables": False,
23122312
"transform_type_categorical": "part_id",
23132313
"transform_type_numerical": "part_id",
2314-
"transform_pairs": "part_id",
2314+
"transform_type_pairs": "part_id",
23152315
},
23162316
)
23172317

@@ -2334,7 +2334,7 @@ def test_parameter_transfer_encoder_fit_from_multitable_dataframe(self):
23342334
"keep_initial_variables": False,
23352335
"transform_type_categorical": "part_id",
23362336
"transform_type_numerical": "part_id",
2337-
"transform_pairs": "part_id",
2337+
"transform_type_pairs": "part_id",
23382338
},
23392339
)
23402340

@@ -2357,7 +2357,7 @@ def test_parameter_transfer_encoder_fit_from_multitable_file_dataset(self):
23572357
"keep_initial_variables": False,
23582358
"transform_type_categorical": "part_id",
23592359
"transform_type_numerical": "part_id",
2360-
"transform_pairs": "part_id",
2360+
"transform_type_pairs": "part_id",
23612361
},
23622362
)
23632363

0 commit comments

Comments
 (0)