Skip to content

Commit ca33f61

Browse files
author
Thierry RAMORASOAVINA
committed
Remove a useless skip condition against a conda env in test_remote_access.py
1 parent 845b918 commit ca33f61

1 file changed

Lines changed: 0 additions & 24 deletions

File tree

tests/test_remote_access.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,6 @@ def remote_access_test_case(self):
139139
"""To be overridden by descendants"""
140140
return ""
141141

142-
def should_skip_in_a_conda_env(self):
143-
"""To be overridden by descendants"""
144-
return True
145-
146142
def print_test_title(self):
147143
print(f"\n Remote System: {self.remote_access_test_case()}")
148144

@@ -181,11 +177,6 @@ def setUp(self):
181177
KhiopsTestHelper.skip_expensive_test(self)
182178

183179
self.skip_if_no_config()
184-
if self.is_in_a_conda_env() and self.should_skip_in_a_conda_env():
185-
self.skipTest(
186-
f"Remote test case {self.remote_access_test_case()} "
187-
"in a conda environment is currently skipped"
188-
)
189180
self.print_test_title()
190181

191182
# Save the runner that can be modified by the test
@@ -353,11 +344,6 @@ def tearDownClass(cls):
353344
if s3_config_exists():
354345
kh.get_runner().__init__()
355346

356-
def should_skip_in_a_conda_env(self):
357-
# The S3 driver is now released for conda too.
358-
# No need to skip the tests any longer in a conda environment
359-
return False
360-
361347
def config_exists(self):
362348
return s3_config_exists()
363349

@@ -398,11 +384,6 @@ def tearDownClass(cls):
398384
if gcs_config_exists():
399385
kh.get_runner().__init__()
400386

401-
def should_skip_in_a_conda_env(self):
402-
# The GCS driver is now released for conda too.
403-
# No need to skip the tests any longer in a conda environment
404-
return False
405-
406387
def config_exists(self):
407388
return gcs_config_exists()
408389

@@ -585,11 +566,6 @@ def tearDownClass(cls):
585566
def config_exists(self):
586567
return docker_runner_config_exists()
587568

588-
def should_skip_in_a_conda_env(self):
589-
# Tests using a docker runner should never be skipped
590-
# even in a conda environment
591-
return False
592-
593569
def remote_access_test_case(self):
594570
return "KhiopsDockerRunner"
595571

0 commit comments

Comments
 (0)