312 accept types in internal csv reading function#314
Merged
folmos-at-orange merged 2 commits intodevfrom Jan 8, 2025
Merged
Conversation
c579618 to
b21e13c
Compare
b21e13c to
bd99eaa
Compare
popescu-v
reviewed
Jan 6, 2025
popescu-v
reviewed
Jan 6, 2025
popescu-v
reviewed
Jan 6, 2025
popescu-v
reviewed
Jan 6, 2025
popescu-v
reviewed
Jan 6, 2025
popescu-v
reviewed
Jan 6, 2025
popescu-v
reviewed
Jan 6, 2025
632bdf1 to
2bfa5d5
Compare
popescu-v
reviewed
Jan 7, 2025
popescu-v
approved these changes
Jan 7, 2025
6d672b5 to
0527279
Compare
We do this only for KhiopsClassifier and KhiopsRegressor: It is critical for KhiopsClassifier as it accepts many target types and it is trivial in the case of KhiopsRegressor. For KhiopsEncoder and KhiopsCoclustering is less critical and for the first one it is very complex. We left them as TODO's. Additionaly, we now also check in the "output type" tests that the result of predict is correct. Before we only checked only that the classes_ attribute was ok. This is to further ensure correctness.
0527279 to
3bf819f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable an easier implementation of #74 and #74 in #306.
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html