370 improve deprecation path for data paths#373
Merged
Conversation
popescu-v
force-pushed
the
370-improve-deprecation-path-for-data-paths
branch
from
926d113 to
cf2da77
Compare
folmos-at-orange
requested changes
Mar 27, 2025
Namely, detect previous-style data paths if: - they contain '`', and, - their first fragment (after split on '`') is identical to the name of one dictionary from the domain.
popescu-v
force-pushed
the
370-improve-deprecation-path-for-data-paths
branch
4 times, most recently
from
36e3d9c to
bc5b5ed
Compare
popescu-v
force-pushed
the
370-improve-deprecation-path-for-data-paths
branch
from
bc5b5ed to
afa14d0
Compare
More specifically, preprocess the data paths in the `additional_data_tables` and `output_additional_data_tables` arguments: - split each path on "`" - check that each data path fragment after the split is non-empty - check that the first fragment is identical to the the name of the current dictionary (as specified in `dictionary_name` or `train_dictionary_name`) If all these conditions are met, then convert the legacy data path to the new format: - drop the current dictionary name fragment from the beginning of the path - join the remaining data path fragments on "/" Note: This does not handle external tables, but for the impending beta, this seems like an acceptable tradeoff. closes #370
popescu-v
force-pushed
the
370-improve-deprecation-path-for-data-paths
branch
from
afa14d0 to
6142e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #370
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html