Fix sklearn tree importances retrieval bug#376
Merged
folmos-at-orange merged 1 commit intodevfrom Mar 28, 2025
Merged
Conversation
When obtaining the tree feature kpis we access the JSON report path `treePreparationReport.variablesStatistics`. If there are informative variables but no informative tree `variablesStatistics` is not defined. We didn't check that and it lead to a bug in this rare case.
popescu-v
approved these changes
Mar 28, 2025
Collaborator
popescu-v
left a comment
popescu-v
left a comment
There was a problem hiding this comment.
LGTM.
To be backported to dev-v10 as well.
folmos-at-orange
added a commit
that referenced
this pull request
Mar 28, 2025
When obtaining the tree feature kpis we access the JSON report path `treePreparationReport.variablesStatistics`. If there are informative variables but no informative tree `variablesStatistics` is not defined. We didn't check that and it lead to a bug in this rare case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When obtaining the tree feature KPIS we access the JSON report path
treePreparationReport.variablesStatistics. If there are informative variables but no informative treevariablesStatisticsis not defined. We didn't check that and it lead to a bug in this rare case.TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html