Skip to content

Fix sklearn tree importances retrieval bug (backport v10) #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
folmos-at-orange merged 1 commit into from
Mar 28, 2025
Merged

Fix sklearn tree importances retrieval bug (backport v10) #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
### Added
- (`sklearn`) Support for boolean and float targets in `KhiopsClassifier`.

### Fixed
- (`sklearn`) Crash when there were no informative trees in predictors.

## 10.3.0.0 - 2025-02-10

### Fixed
Expand Down
12 changes: 8 additions & 4 deletions khiops/sklearn/estimators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1674,10 +1674,14 @@ def _fit_training_post_process(self, ds):
else:
pair_feature_evaluated_names_ = []
pair_feature_evaluated_levels_ = []
if "treePreparationReport" in self.model_report_raw_:
tree_preparation_report = self.model_report_raw_["treePreparationReport"][
"variablesStatistics"
]
if (
"treePreparationReport" in self.model_report_.json_data
and "variablesStatistics"
in self.model_report_.json_data["treePreparationReport"]
):
tree_preparation_report = self.model_report_.json_data[
"treePreparationReport"
]["variablesStatistics"]
tree_feature_evaluated_names_ = [
tree_preparation_report[i]["name"]
for i in range(0, len(tree_preparation_report))
Expand Down