Make build_multi_table_dictionary_domain private by convention#396
Merged
Conversation
popescu-v
force-pushed
the
395-backport-v11
branch
from
ff342ce to
f63f2ec
Compare
folmos-at-orange
approved these changes
Apr 15, 2025
folmos-at-orange
approved these changes
Apr 15, 2025
Eliminate the eponymous public (by convention) function, deprecated in v10. Partial backport of the relevant v10 change c942f3f.
popescu-v
force-pushed
the
395-backport-v11
branch
from
f63f2ec to
669d1d2
Compare
Collaborator
Author
OK, done. |
tramora
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate the eponymous public (by convention) function, deprecated in v10.
Partial backport of the relevant v10 change c942f3f.
TODO Before Asking for a Review
dev(ormainfor release PRs)index.html