331 update json report structure for v11 by popescu-v · Pull Request #403 · KhiopsML/khiops-python

popescu-v · 2025-04-30T17:47:44Z

Put your message here

TODO Before Asking for a Review

Rebase your branch to the latest version of dev (or main for release PRs)
Make sure all CI workflows are green
When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
Self-Review: Review "Files Changed" tab and fix any problems you find
API Docs (only if there are changes in docstrings, rst files or samples):
- Check the docs build without warning: see the log of the API Docs workflow
- Check that your changes render well in HTML: download the API Docs artifact and open index.html
- If there are any problems it is faster to iterate by building locally the API Docs

folmos-at-orange

All minor issues.

Commit name changes:

e41dcd4 Also remove tools auto-generated RST documentation files upon doc cleaning
- Remove Also
d646e7b Drop tests on typicalities, as they are no longer mandatory
- Remove the reason or put it in the body. You can even explain more thoroughly why they are not mandatory anymore.

khiops/core/analysis_results.py

tests/test_core.py

khiops/core/analysis_results.py

Update analysis report object structure: - add missing_number for Categorical variables as well - add sparse_missing_number for both Numerical and Categorical variables - add number of text features - add text preparation report

khiops/core/analysis_results.py

tests/test_core.py

khiops/core/analysis_results.py

tests/test_core.py

Use it throughout the code base where needed: in the sklearn estimators and their tests.

…eferences Remove CSV report references, as they are no longer needed.

They are no longer always mandatory, namely when used in the `innerVariables` part of instance-variable coclustering reports.

Also, don't count them in test coverage reports.

khiops/core/analysis_results.py

khiops/core/internals/io.py

…trings

…atistics

closes #409

khiops/core/coclustering_results.py

khiops/core/internals/io.py

tests/test_core.py

Thus, the `write_khiops_json_file` method can be used to dump the JSON report with the keys exactly in the same order as expected by MODL_Coclustering. Thus, coclustering reports are now verbatim-identical to the reference reports.

popescu-v linked an issue Apr 30, 2025 that may be closed by this pull request

Update JSON Report Structure for v11 #331

Closed

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch 4 times, most recently from 2946859 to 3ce34c7 Compare May 7, 2025 17:39

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch 3 times, most recently from 0d2cd5e to dccebf7 Compare May 16, 2025 10:31

popescu-v marked this pull request as ready for review May 16, 2025 10:32

popescu-v requested a review from folmos-at-orange May 16, 2025 10:33

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch from dccebf7 to e41dcd4 Compare May 16, 2025 12:46

folmos-at-orange requested changes May 19, 2025

View reviewed changes

folmos-at-orange reviewed May 19, 2025

View reviewed changes

khiops/core/analysis_results.py Show resolved Hide resolved

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch 3 times, most recently from 3865981 to ca3bde7 Compare May 20, 2025 16:29

Update JSON reference reports to v11

aeced01

Update analysis report object structure: - add missing_number for Categorical variables as well - add sparse_missing_number for both Numerical and Categorical variables - add number of text features - add text preparation report

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch 2 times, most recently from 4edfc7a to 3a20245 Compare May 21, 2025 16:56

folmos-at-orange linked an issue May 22, 2025 that may be closed by this pull request

Update the default samples version to be downloaded with kh-download-datasets #409

Closed

folmos-at-orange requested changes May 22, 2025

View reviewed changes

popescu-v added 4 commits May 22, 2025 13:09

Add analysis reporting JSONization support

e4d1ce4

Drop no-longer-used map SelectedVariable attribute

e361e66

Deprecate .json_data on KhiopsJSONObject

c87331e

Add MODL histogram support to the analysis results object

9fc1089

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch 2 times, most recently from 1f09338 to 38b85d7 Compare May 22, 2025 13:03

folmos-at-orange requested changes May 22, 2025

View reviewed changes

tests/test_core.py Outdated Show resolved Hide resolved

popescu-v added 2 commits May 22, 2025 17:12

Add tree details support to the AnalysisResults object

5d1eb31

Use it throughout the code base where needed: in the sklearn estimators and their tests.

Rename ModlHistogram to ModlHistograms to reflect plurality

c386986

popescu-v added 3 commits May 22, 2025 17:16

Update reports core tests to use to_json methods with the updated r…

10a6dd6

…eferences Remove CSV report references, as they are no longer needed.

Drop tests on typicalities

72b0970

They are no longer always mandatory, namely when used in the `innerVariables` part of instance-variable coclustering reports.

Deprecate CSV report writing methods

70eac6b

Also, don't count them in test coverage reports.

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch from 05c6ffb to aa50d45 Compare May 22, 2025 15:16

folmos-at-orange approved these changes May 22, 2025

View reviewed changes

khiops/core/analysis_results.py Outdated Show resolved Hide resolved

khiops/core/internals/io.py Outdated Show resolved Hide resolved

popescu-v added 5 commits May 22, 2025 20:32

Rename to_json to to_dict and update its and report modules' docs…

3f0f825

…trings

Reorder PreparationReport methods: put get_tree after get_variable_st…

6e38f14

…atistics

Use plain method names in deprecation warnings for more code readability

cbbe552

Update samples version to 11.0.0 in kh-download-samples

6319ae2

closes #409

Remove tools auto-generated RST documentation files upon doc cleaning

b296bdb

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch 2 times, most recently from 1bdfd54 to b7045e9 Compare May 23, 2025 17:38

folmos-at-orange requested changes May 26, 2025

View reviewed changes

khiops/core/coclustering_results.py Outdated Show resolved Hide resolved

khiops/core/internals/io.py Outdated Show resolved Hide resolved

khiops/core/internals/io.py Outdated Show resolved Hide resolved

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch from b7045e9 to 013dbc0 Compare May 26, 2025 14:57

folmos-at-orange requested changes May 26, 2025

View reviewed changes

khiops/core/internals/io.py Show resolved Hide resolved

khiops/core/internals/io.py Outdated Show resolved Hide resolved

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch 2 times, most recently from 9764332 to 13c10c2 Compare May 26, 2025 16:23

folmos-at-orange approved these changes May 26, 2025

View reviewed changes

khiops/core/internals/io.py Show resolved Hide resolved

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch from 13c10c2 to b2f11cd Compare May 26, 2025 17:56

folmos-at-orange approved these changes May 26, 2025

View reviewed changes

tests/test_core.py Outdated Show resolved Hide resolved

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch from b2f11cd to 0b7a95f Compare May 26, 2025 18:17

folmos-at-orange approved these changes May 26, 2025

View reviewed changes

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch from 0b7a95f to 968bbc7 Compare May 27, 2025 08:59

popescu-v force-pushed the 331-update-json-report-structure-for-v11 branch from 968bbc7 to 1e306b2 Compare May 27, 2025 09:00

popescu-v merged commit b76aeb1 into dev May 27, 2025
19 checks passed

popescu-v deleted the 331-update-json-report-structure-for-v11 branch May 27, 2025 10:43

This was referenced Aug 4, 2025

Refactor Analysis Report Testing Code #384

Closed

Generate khcj with CoclusteringResults #69

Closed

popescu-v mentioned this pull request Aug 25, 2025

Support the tree preparation report #35

Closed

Conversation

popescu-v commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO Before Asking for a Review

Uh oh!

folmos-at-orange left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

popescu-v commented Apr 30, 2025 •

edited

Loading