Skip to content

Add support for the new multi-table schema spec in the s…#421

Merged
popescu-v merged 3 commits intodevfrom
400-exploit-a-hierarchical-multi-table-schema-for-sklearn-api
Jul 9, 2025
Merged

Add support for the new multi-table schema spec in the s…#421
popescu-v merged 3 commits intodevfrom
400-exploit-a-hierarchical-multi-table-schema-for-sklearn-api

Conversation

@popescu-v
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v commented Jun 23, 2025 •
edited
Loading

  • support the new syntax for X
  • deprecate the old syntax: warn the user and transform it to the new syntax.

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v linked an issue Jun 23, 2025 that may be closed by this pull request
Exploit a hierarchical multi-table schema for sklearn API #400
Closed
folmos-at-orange
folmos-at-orange requested changes Jun 23, 2025
View reviewed changes
folmos-at-orange
folmos-at-orange reviewed Jun 23, 2025
View reviewed changes
folmos-at-orange
folmos-at-orange reviewed Jun 23, 2025
View reviewed changes
@popescu-v popescu-v changed the title WIP Start adding support for the new multi-table schema spec in the s… Add support for the new multi-table schema spec in the s… Jun 25, 2025
@popescu-v popescu-v force-pushed the 400-exploit-a-hierarchical-multi-table-schema-for-sklearn-api branch from 4a577ad to 947db01 Compare June 25, 2025 18:52
@popescu-v popescu-v marked this pull request as ready for review June 25, 2025 18:58
folmos-at-orange
folmos-at-orange requested changes Jun 26, 2025
View reviewed changes
@popescu-v popescu-v force-pushed the 400-exploit-a-hierarchical-multi-table-schema-for-sklearn-api branch 4 times, most recently from 03dfeba to 05fd0cf Compare July 7, 2025 14:08
folmos-at-orange
folmos-at-orange requested changes Jul 7, 2025
View reviewed changes
@popescu-v popescu-v force-pushed the 400-exploit-a-hierarchical-multi-table-schema-for-sklearn-api branch 3 times, most recently from 9b2a022 to ddaa5fc Compare July 9, 2025 10:56
@popescu-v popescu-v force-pushed the 400-exploit-a-hierarchical-multi-table-schema-for-sklearn-api branch from ddaa5fc to e061a74 Compare July 9, 2025 14:20
@popescu-v popescu-v merged commit 07b369f into dev Jul 9, 2025
29 checks passed
@popescu-v popescu-v deleted the 400-exploit-a-hierarchical-multi-table-schema-for-sklearn-api branch July 9, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folmos-at-orange folmos-at-orange folmos-at-orange approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exploit a hierarchical multi-table schema for sklearn API

2 participants

@popescu-v @folmos-at-orange