Skip to content

Prepare release 10 3 2 0#427

Merged
popescu-v merged 9 commits intodev-v10from
prepare-release-10-3-2-0
Jul 4, 2025
Merged

Prepare release 10 3 2 0#427
popescu-v merged 9 commits intodev-v10from
prepare-release-10-3-2-0

Conversation

@popescu-v
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v commented Jul 3, 2025 •
edited
Loading

Prepare release 10.3.2.0

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v marked this pull request as ready for review July 3, 2025 12:22
@popescu-v
Drop the windows-2019 runner at is has been phased out
37642a5 
See actions/runner-images#12045.

Replace it with the windows-2022 runner, and the windows-2022 runner
with the windows-2025 runner.
@popescu-v popescu-v force-pushed the prepare-release-10-3-2-0 branch 4 times, most recently from 35d3f4e to a4c7882 Compare July 3, 2025 16:47
popescu-v added 2 commits July 3, 2025 19:04
@popescu-v
%CONDA_PREFIX%\bin does not exist anymore on Windows
f8cf2e1 
Only %CONDA_PREFIX%\Library\bin exists.
@popescu-v
The MPI command is not always called mpiexec anymore
306a62f 
It can be orterun, etc. Hence, we test that it is not <empty>.
@popescu-v popescu-v force-pushed the prepare-release-10-3-2-0 branch from a4c7882 to 306a62f Compare July 3, 2025 17:04
@popescu-v popescu-v requested a review from tramora July 3, 2025 17:23
@popescu-v popescu-v linked an issue Jul 3, 2025 that may be closed by this pull request
Prepare 10.3.2.0 release #418
Closed
25 tasks
@tramora
Copy link
Copy Markdown
Collaborator

tramora commented Jul 3, 2025

Except a suprising change of the khiops core binaries location on Windows, the remaining seems OK for me

@popescu-v
Copy link
Copy Markdown
Collaborator Author

popescu-v commented Jul 4, 2025

Except a suprising change of the khiops core binaries location on Windows, the remaining seems OK for me

This change is due to the conda-forge recipe specifics; see https://github.com/conda-forge/khiops-binaries-feedstock, more specifically: https://github.com/conda-forge/khiops-binaries-feedstock/blob/7aaf7abc0f76dd482319d6cdbc6186fc1129657b/recipe/bld.bat#L21

tramora
tramora approved these changes Jul 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tramora tramora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation about the new khiops core bin location is clear

@popescu-v popescu-v merged commit a3e412c into dev-v10 Jul 4, 2025
88 checks passed
@popescu-v popescu-v deleted the prepare-release-10-3-2-0 branch July 4, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tramora tramora tramora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prepare 10.3.2.0 release

2 participants

@popescu-v @tramora