Migrate to pyproject toml#441
Merged
Merged
Conversation
Notes: - setup.py is still needed for versioneer support. - versioneer.py vendoring is needed for Conda packaging (so that the version can be available to meta.yaml before the building itself). related_to #411
popescu-v
force-pushed
the
migrate-to-pyproject-toml-v11
branch
7 times, most recently
from
July 30, 2025 11:27
0845b4f to
87b8197
Compare
popescu-v
force-pushed
the
migrate-to-pyproject-toml-v11
branch
6 times, most recently
from
July 30, 2025 16:39
854f1e2 to
d578542
Compare
Notes: - the version is hard-coded in the khiops/__init__.py file and not in pyproject.toml, because pyproject.toml is not accessible at runtime for an installed package - conda-build does not support pyproject.toml-style dynamic versions, hence the version has to be hard-coded in conda/meta.yaml as well - when moving to conda-forge, the version would have to be hard-coded anyway - the khiops/__init__.py vs conda/meta.yaml version coherence is checked in the conda package building and testing workflow.
popescu-v
force-pushed
the
migrate-to-pyproject-toml-v11
branch
from
July 30, 2025 17:05
d578542 to
f052165
Compare
Collaborator
|
Except a few questions I do not have any blocking remark |
tramora
reviewed
Jul 31, 2025
tramora
self-requested a review
August 2, 2025 23:49
tramora
approved these changes
Aug 2, 2025
popescu-v
force-pushed
the
migrate-to-pyproject-toml-v11
branch
2 times, most recently
from
August 4, 2025 16:05
a60685b to
67ea814
Compare
popescu-v
force-pushed
the
migrate-to-pyproject-toml-v11
branch
from
August 4, 2025 16:33
67ea814 to
f87b040
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #411
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html