List all possible variable types in class Variable docstring#452
Merged
Conversation
tramora
force-pushed
the
440-document-possible-variable-types
branch
from
4683aa5 to
7aca86b
Compare
tramora
force-pushed
the
440-document-possible-variable-types
branch
4 times, most recently
from
3bfdc95 to
397f77a
Compare
tramora
force-pushed
the
440-document-possible-variable-types
branch
3 times, most recently
from
884be94 to
1a2045e
Compare
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
khiops/samples/samples.py
Outdated
| var.type = var_spec["type"] | ||
| root_dictionary.add_variable(var) | ||
|
|
||
| # Creates a second dictionary (not linked yet) |
Collaborator
There was a problem hiding this comment.
s/Creates/Create/
"(not linked yet)": what does this mean?
Collaborator
Author
There was a problem hiding this comment.
typo fixed.
The link is created when a Entity or Table variable is added but if it is confusing I will remove it
Collaborator
There was a problem hiding this comment.
typo fixed.
The link is created when a Entity or Table variable is added but if it is confusing I will remove it
Yes, I would remove the text between the parentheses (as the "link" concept is not defined).
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
popescu-v
reviewed
Sep 3, 2025
tramora
force-pushed
the
440-document-possible-variable-types
branch
2 times, most recently
from
ac7bd7c to
5344e67
Compare
popescu-v
reviewed
Sep 3, 2025
khiops/samples/samples.py
Outdated
| kh.Variable(json_data={"name": "id_city", "type": "Categorical"}) | ||
| ) | ||
|
|
||
| # Add the variables used in a Multi-tables context in the first dictionary. |
Collaborator
There was a problem hiding this comment.
s/Multi-tables/multi-table/ (for coherence with other occurrences in the samples).
popescu-v
approved these changes
Sep 3, 2025
Collaborator
There was a problem hiding this comment.
LGTM, could be merged after #452 (comment) and #452 (comment) are taken into account.
tramora
force-pushed
the
440-document-possible-variable-types
branch
from
5344e67 to
0e98c12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html