Merged
Conversation
tramora
reviewed
Aug 19, 2025
Collaborator
|
Looks fine to me. I have just a question about the usage |
tramora
approved these changes
Aug 19, 2025
folmos-at-orange
requested changes
Aug 19, 2025
- add comments to Dictionary, Variable and VariableBlock objects; - add internal comments to Dictionary and VariableBlock objects. Note: the position of the comments that are interspersed with dictionary information (e.g. before/after key, before/after metadata, etc.) cannot be reconstructed, because kdic file parsing gets the correct comment *attachments* to the entities they apply to, but not their textual position with respect to these entities. The attachments are sufficient for constituting the JSON dictionary representations though. Hence, semantically no information is lost upon parsing.
4fdfc24 to
bc454b6
Compare
folmos-at-orange
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the position of the comments that are interspersed with dictionary information (e.g. before/after key, before/after metadata, etc.) cannot be reconstructed, because kdic file parsing gets the correct comment attachments to the entities they apply to, but not their textual position with respect to these entities. The attachments are sufficient for constituting the JSON dictionary representations though. Hence, semantically no information is lost upon DictionaryDomain object initialization from the JSON file that is generated by Khiops Core via the
export_dictionary_as_jsonCore API function.closes #423
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html