Skip to content

Make tools.download_datasets consistent with the runner#460

Merged
popescu-v merged 4 commits intodevfrom
454-unconsistence-between-download_datasets-and-get_samples_dir
Aug 25, 2025
Merged

Make tools.download_datasets consistent with the runner#460
popescu-v merged 4 commits intodevfrom
454-unconsistence-between-download_datasets-and-get_samples_dir

Conversation

@popescu-v
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v commented Aug 21, 2025 •
edited
Loading

closes #454

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v self-assigned this Aug 21, 2025
@popescu-v popescu-v linked an issue Aug 21, 2025 that may be closed by this pull request
Inconsistence between download_datasets and get_samples_dir #454
Closed
@popescu-v popescu-v force-pushed the 454-unconsistence-between-download_datasets-and-get_samples_dir branch from 1eef2ed to 0b67e14 Compare August 21, 2025 14:14
@popescu-v popescu-v force-pushed the 454-unconsistence-between-download_datasets-and-get_samples_dir branch 3 times, most recently from 6ca501e to 4c8f62f Compare August 22, 2025 12:28
folmos-at-orange
folmos-at-orange requested changes Aug 22, 2025
View reviewed changes
@popescu-v popescu-v force-pushed the 454-unconsistence-between-download_datasets-and-get_samples_dir branch 2 times, most recently from 6c7211a to 639ba1a Compare August 22, 2025 16:06
tramora
tramora approved these changes Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tramora tramora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@popescu-v popescu-v force-pushed the 454-unconsistence-between-download_datasets-and-get_samples_dir branch 2 times, most recently from fb9a805 to c30da6e Compare August 22, 2025 17:51
folmos-at-orange
folmos-at-orange approved these changes Aug 25, 2025
View reviewed changes
@popescu-v popescu-v force-pushed the 454-unconsistence-between-download_datasets-and-get_samples_dir branch from c30da6e to e07cbc8 Compare August 25, 2025 12:08
@popescu-v popescu-v merged commit 111996c into dev Aug 25, 2025
29 checks passed
@popescu-v popescu-v deleted the 454-unconsistence-between-download_datasets-and-get_samples_dir branch August 25, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folmos-at-orange folmos-at-orange folmos-at-orange approved these changes

@tramora tramora tramora approved these changes

Assignees

@popescu-v popescu-v

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistence between download_datasets and get_samples_dir

3 participants

@popescu-v @tramora @folmos-at-orange