59 add api to specify dictionary rules by popescu-v · Pull Request #467 · KhiopsML/khiops-python

popescu-v · 2025-09-02T16:21:12Z

closes #59

TODO Before Asking for a Review

Rebase your branch to the latest version of dev (or main for release PRs)
Make sure all CI workflows are green
When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
Self-Review: Review "Files Changed" tab and fix any problems you find
API Docs (only if there are changes in docstrings, rst files or samples):
- Check the docs build without warning: see the log of the API Docs workflow
- Check that your changes render well in HTML: download the API Docs artifact and open index.html
- If there are any problems it is faster to iterate by building locally the API Docs

CHANGELOG.md

khiops/core/dictionary.py

doc/samples/samples.rst

folmos-at-orange

I'd also add some tests for the Rule class.

khiops/core/dictionary.py

popescu-v · 2025-09-04T15:09:15Z

I'd also add some tests for the Rule class.

Tests added.

tests/test_core.py

khiops/core/dictionary.py

tests/test_core.py

khiops/core/dictionary.py

tests/test_core.py

khiops/core/dictionary.py

The first character can also be an underscore.

khiops/core/dictionary.py

tramora

Looks good to me. I had a couple of questions but I have the anwsers now.

khiops/core/dictionary.py

- add a `Rule` class which supports: - standard rules - reference rules - rules provided as verbatims - add `{Variable,VariableBlock}.{get,set}_rule` methods - add an `upper_scope` function which applies the upper-scope operand `.` to `Variable` and `Rule` instances and to upper-scoped instances of these.

popescu-v self-assigned this Sep 2, 2025

popescu-v requested review from folmos-at-orange and tramora September 2, 2025 16:21

popescu-v linked an issue Sep 2, 2025 that may be closed by this pull request

Add API to specify Dictionary rules #59

Closed

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 4 times, most recently from b77247d to a6e9eee Compare September 3, 2025 16:46

popescu-v mentioned this pull request Sep 3, 2025

List all possible variable types in class Variable docstring #452

Merged

6 tasks

folmos-at-orange requested changes Sep 4, 2025

View reviewed changes

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 3 times, most recently from 8a282b0 to e054925 Compare September 4, 2025 13:00

folmos-at-orange requested changes Sep 4, 2025

View reviewed changes

khiops/core/dictionary.py Outdated Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from e054925 to 6c1aab4 Compare September 4, 2025 15:09

folmos-at-orange approved these changes Sep 4, 2025

View reviewed changes

tests/test_core.py Outdated Show resolved Hide resolved

tests/test_core.py Show resolved Hide resolved

tests/test_core.py Outdated Show resolved Hide resolved

tests/test_core.py Outdated Show resolved Hide resolved

tests/test_core.py Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 4 times, most recently from cd24c31 to 984dfce Compare September 5, 2025 12:05

folmos-at-orange requested changes Sep 5, 2025

View reviewed changes

khiops/core/dictionary.py Outdated Show resolved Hide resolved

khiops/core/dictionary.py Show resolved Hide resolved

khiops/core/dictionary.py Show resolved Hide resolved

khiops/core/dictionary.py Outdated Show resolved Hide resolved

tests/test_core.py Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from 984dfce to c4b587c Compare September 5, 2025 15:39

folmos-at-orange requested changes Sep 8, 2025

View reviewed changes

khiops/core/dictionary.py Outdated Show resolved Hide resolved

khiops/core/dictionary.py Outdated Show resolved Hide resolved

khiops/core/dictionary.py Outdated Show resolved Hide resolved

khiops/core/dictionary.py Outdated Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from c4b587c to 8683802 Compare September 8, 2025 09:23

folmos-at-orange approved these changes Sep 8, 2025

View reviewed changes

tests/test_core.py Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from 0d81579 to b623806 Compare September 9, 2025 17:43

folmos-at-orange self-requested a review September 10, 2025 07:56

folmos-at-orange approved these changes Sep 10, 2025

View reviewed changes

Update Core API docstrings to silence Sphinx warnings

6c68969

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from 7fbeb4f to 6065cf1 Compare September 10, 2025 11:52

folmos-at-orange approved these changes Sep 10, 2025

View reviewed changes

khiops/core/dictionary.py Outdated Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from c5e8af2 to e0c6e5d Compare September 10, 2025 15:53

folmos-at-orange approved these changes Sep 10, 2025

View reviewed changes

khiops/core/dictionary.py Outdated Show resolved Hide resolved

khiops/core/dictionary.py Outdated Show resolved Hide resolved

khiops/core/dictionary.py Outdated Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from 8a5fc07 to 50945ee Compare September 10, 2025 18:39

popescu-v added 2 commits September 11, 2025 15:14

Support bytes verbatim rules in Variable.is_reference_rule

9b90c2c

Update identifier name pattern to match Core

c8fbe9e

The first character can also be an underscore.

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from 50945ee to d4bddc8 Compare September 11, 2025 13:15

folmos-at-orange requested changes Sep 11, 2025

View reviewed changes

tramora reviewed Sep 11, 2025

View reviewed changes

khiops/core/dictionary.py Show resolved Hide resolved

tramora reviewed Sep 11, 2025

View reviewed changes

khiops/core/dictionary.py Show resolved Hide resolved

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from d4bddc8 to de21839 Compare September 11, 2025 13:58

tramora approved these changes Sep 11, 2025

View reviewed changes

folmos-at-orange approved these changes Sep 11, 2025

View reviewed changes

popescu-v added 2 commits September 11, 2025 17:26

Update CHANGELOG

a4ef9e5

popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from de21839 to a4ef9e5 Compare September 11, 2025 15:26

popescu-v merged commit 1b0b3dc into dev Sep 12, 2025
95 checks passed

popescu-v deleted the 59-add-api-to-specify-dictionary-rules branch September 12, 2025 13:50

popescu-v mentioned this pull request Sep 23, 2025

Update How-To's to Using the Rule and Add Variable from Spec Dictionary APIs KhiopsML/khiops-doc#147

Open

Conversation

popescu-v commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO Before Asking for a Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

folmos-at-orange left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

popescu-v commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tramora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

popescu-v commented Sep 2, 2025 •

edited

Loading