Skip to content

59 add api to specify dictionary rules#467

Merged
popescu-v merged 5 commits into
devfrom
59-add-api-to-specify-dictionary-rules
Sep 12, 2025
Merged

59 add api to specify dictionary rules#467
popescu-v merged 5 commits into
devfrom
59-add-api-to-specify-dictionary-rules

Conversation

@popescu-v
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v commented Sep 2, 2025 •
edited
Loading

closes #59

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v self-assigned this Sep 2, 2025
@popescu-v popescu-v linked an issue Sep 2, 2025 that may be closed by this pull request
Add API to specify Dictionary rules #59
Closed
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 4 times, most recently from b77247d to a6e9eee Compare September 3, 2025 16:46
@popescu-v popescu-v mentioned this pull request Sep 3, 2025
Merged
6 tasks
folmos-at-orange
folmos-at-orange requested changes Sep 4, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread doc/samples/samples.rst Outdated
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 3 times, most recently from 8a282b0 to e054925 Compare September 4, 2025 13:00
folmos-at-orange
folmos-at-orange requested changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@folmos-at-orange folmos-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add some tests for the Rule class.

Comment thread khiops/core/dictionary.py Outdated
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from e054925 to 6c1aab4 Compare September 4, 2025 15:09
@popescu-v
Copy link
Copy Markdown
Collaborator Author

popescu-v commented Sep 4, 2025

I'd also add some tests for the Rule class.

Tests added.

folmos-at-orange
folmos-at-orange approved these changes Sep 4, 2025
View reviewed changes
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 4 times, most recently from cd24c31 to 984dfce Compare September 5, 2025 12:05
folmos-at-orange
folmos-at-orange requested changes Sep 5, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py
Comment thread khiops/core/dictionary.py
Comment thread khiops/core/dictionary.py Outdated
Comment thread tests/test_core.py
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from 984dfce to c4b587c Compare September 5, 2025 15:39
folmos-at-orange
folmos-at-orange requested changes Sep 8, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from c4b587c to 8683802 Compare September 8, 2025 09:23
folmos-at-orange
folmos-at-orange approved these changes Sep 8, 2025
View reviewed changes
Comment thread tests/test_core.py
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from 0d81579 to b623806 Compare September 9, 2025 17:43
@folmos-at-orange folmos-at-orange self-requested a review September 10, 2025 07:56
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from 7fbeb4f to 6065cf1 Compare September 10, 2025 11:52
folmos-at-orange
folmos-at-orange approved these changes Sep 10, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py Outdated
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from c5e8af2 to e0c6e5d Compare September 10, 2025 15:53
folmos-at-orange
folmos-at-orange approved these changes Sep 10, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch 2 times, most recently from 8a5fc07 to 50945ee Compare September 10, 2025 18:39
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from 50945ee to d4bddc8 Compare September 11, 2025 13:15
folmos-at-orange
folmos-at-orange requested changes Sep 11, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
tramora
tramora reviewed Sep 11, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py
tramora
tramora reviewed Sep 11, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from d4bddc8 to de21839 Compare September 11, 2025 13:58
tramora
tramora approved these changes Sep 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tramora tramora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I had a couple of questions but I have the anwsers now.

folmos-at-orange
folmos-at-orange approved these changes Sep 11, 2025
View reviewed changes
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
Comment thread khiops/core/dictionary.py Outdated
@popescu-v
Add Khiops dictionary rule API support
cd65017 
- add a `Rule` class which supports:
  - standard rules
  - reference rules
  - rules provided as verbatims
- add `{Variable,VariableBlock}.{get,set}_rule` methods
- add an `upper_scope` function which applies the upper-scope operand
  `.` to `Variable` and `Rule` instances and to upper-scoped instances
  of these.
@popescu-v
Update CHANGELOG
a4ef9e5
@popescu-v popescu-v force-pushed the 59-add-api-to-specify-dictionary-rules branch from de21839 to a4ef9e5 Compare September 11, 2025 15:26
@popescu-v popescu-v merged commit 1b0b3dc into dev Sep 12, 2025
95 checks passed
@popescu-v popescu-v deleted the 59-add-api-to-specify-dictionary-rules branch September 12, 2025 13:50
@popescu-v popescu-v mentioned this pull request Sep 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folmos-at-orange folmos-at-orange folmos-at-orange approved these changes

@tramora tramora tramora approved these changes

Assignees

@popescu-v popescu-v

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add API to specify Dictionary rules

3 participants

@popescu-v @tramora @folmos-at-orange